Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: accept blob id from caller #562

Closed
wants to merge 1 commit into from
Closed

refactor: accept blob id from caller #562

wants to merge 1 commit into from

Conversation

forehalo
Copy link
Member

No description provided.

Copy link

vercel bot commented Dec 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
octobase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 25, 2023 5:54am

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (49a6b7a) 65.66% compared to head (971a932) 65.72%.

Files Patch % Lines
apps/keck/src/server/sync/blobs.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #562      +/-   ##
==========================================
+ Coverage   65.66%   65.72%   +0.05%     
==========================================
  Files         118      118              
  Lines       13138    13117      -21     
==========================================
- Hits         8627     8621       -6     
+ Misses       4511     4496      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark for Linux

Click to view benchmark
Test Base PR %
codec/jwst decode var_int (32 bit) 201.6±9.26µs 201.0±0.89µs -0.30%
codec/jwst decode var_uint (32 bit) 170.2±1.57µs 171.5±10.48µs +0.76%
codec/jwst decode var_uint (64 bit) 170.5±0.65µs 173.1±13.75µs +1.52%
codec/jwst encode var_int (32 bit) 302.4±3.21µs 302.4±0.70µs -0.00%
codec/jwst encode var_uint (32 bit) 271.4±8.68µs 268.6±1.28µs -1.03%
codec/jwst encode var_uint (64 bit) 269.2±3.84µs 268.7±2.96µs -0.19%
codec/lib0 decode var_int (64 bit) 162.7±1.76µs 163.3±1.74µs +0.37%
codec/lib0 decode var_uint (32 bit) 142.2±2.03µs 143.0±1.24µs +0.56%
codec/lib0 decode var_uint (64 bit) 135.0±1.41µs 135.3±1.66µs +0.22%
codec/lib0 encode var_int (64 bit) 383.7±1.63µs 385.2±1.15µs +0.39%
codec/lib0 encode var_uint (32 bit) 375.7±15.22µs 374.3±1.11µs -0.37%
codec/lib0 encode var_uint (64 bit) 373.1±1.54µs 374.0±0.57µs +0.24%
ops/array/jwst/insert 111.0±1.91µs 110.0±0.32µs -0.90%
ops/array/jwst/insert range 164.1±1.66µs 165.3±2.85µs +0.73%
ops/array/jwst/remove 62.2±0.30µs 64.3±0.20µs +3.38%
ops/array/yrs/insert 56.5±0.43µs 57.7±0.26µs +2.12%
ops/array/yrs/insert range 72.5±2.06µs 73.8±2.72µs +1.79%
ops/array/yrs/remove 63.4±0.41µs 65.3±0.57µs +3.00%
ops/map/jwst/get 343.2±3.87ns 343.1±5.45ns -0.03%
ops/map/jwst/insert 4.1±0.05µs 4.1±0.02µs -0.00%
ops/map/jwst/remove 4.8±0.02µs 4.8±0.02µs -0.00%
ops/map/yrs/get 245.3±0.85ns 251.4±2.00ns +2.49%
ops/map/yrs/insert 3.8±0.02µs 3.8±0.17µs -0.00%
ops/map/yrs/remove 5.0±0.12µs 5.0±0.02µs -0.00%
ops/text/jwst/insert 68.0±0.69µs 72.9±0.91µs +7.21%
ops/text/jwst/remove 2.1±0.01µs 2.1±0.01µs -0.00%
ops/text/yrs/insert 27.0±0.15µs 27.0±0.12µs -0.00%
ops/text/yrs/remove 1726.1±9.16ns 1694.2±32.41ns -1.85%
update/parse with jwst/basic.bin 37.1±0.29µs 37.7±0.14µs +1.62%
update/parse with jwst/database.bin 28.3±0.18µs 28.3±0.16µs -0.00%
update/parse with jwst/large.bin 1830.4±291.07µs 1796.6±9.20µs -1.85%
update/parse with jwst/with-subdoc.bin 4.6±0.09µs 4.8±0.16µs +4.35%
update/parse with yrs/basic.bin 29.3±0.16µs 29.6±0.21µs +1.02%
update/parse with yrs/database.bin 22.6±0.71µs 23.1±0.15µs +2.21%
update/parse with yrs/large.bin 1320.2±25.25µs 1297.3±15.33µs -1.73%
update/parse with yrs/with-subdoc.bin 4.6±0.08µs 3.9±0.03µs -15.22%

Benchmark for Windows

Click to view benchmark
Test Base PR %
codec/jwst decode var_int (32 bit) 213.8±2.15µs 213.4±1.52µs -0.19%
codec/jwst decode var_uint (32 bit) 195.2±2.15µs 194.9±3.63µs -0.15%
codec/jwst decode var_uint (64 bit) 192.3±3.62µs 192.1±3.40µs -0.10%
codec/jwst encode var_int (32 bit) 302.8±2.00µs 302.7±5.87µs -0.03%
codec/jwst encode var_uint (32 bit) 263.1±1.25µs 269.9±9.40µs +2.58%
codec/jwst encode var_uint (64 bit) 269.3±2.94µs 259.5±2.80µs -3.64%
codec/lib0 decode var_int (64 bit) 190.7±5.63µs 190.8±5.63µs +0.05%
codec/lib0 decode var_uint (32 bit) 158.2±7.83µs 157.0±7.07µs -0.76%
codec/lib0 decode var_uint (64 bit) 168.6±11.76µs 159.4±6.79µs -5.46%
codec/lib0 encode var_int (64 bit) 385.3±1.50µs 385.6±3.25µs +0.08%
codec/lib0 encode var_uint (32 bit) 373.0±0.71µs 373.0±0.90µs -0.00%
codec/lib0 encode var_uint (64 bit) 373.9±3.62µs 373.2±0.93µs -0.19%
ops/array/jwst/insert 153.9±2.18µs 159.3±1.13µs +3.51%
ops/array/jwst/insert range 215.7±1.41µs 216.4±0.87µs +0.32%
ops/array/jwst/remove 94.5±1.00µs 79.1±0.80µs -16.30%
ops/array/yrs/insert 71.8±1.54µs 72.9±0.37µs +1.53%
ops/array/yrs/insert range 97.4±0.54µs 97.9±1.31µs +0.51%
ops/array/yrs/remove 101.2±0.28µs 99.7±0.37µs -1.48%
ops/map/jwst/get 380.7±3.36ns 380.0±2.99ns -0.18%
ops/map/jwst/insert 6.0±0.03µs 8.3±0.06µs +38.33%
ops/map/jwst/remove 6.5±0.03µs 6.6±0.03µs +1.54%
ops/map/yrs/get 275.8±5.01ns 276.7±5.07ns +0.33%
ops/map/yrs/insert 5.8±0.03µs 6.5±0.03µs +12.07%
ops/map/yrs/remove 7.0±0.02µs 7.4±0.05µs +5.71%
ops/text/jwst/insert 88.5±1.00µs 88.1±0.56µs -0.45%
ops/text/jwst/remove 2.5±0.01µs 2.4±0.01µs -4.00%
ops/text/yrs/insert 32.2±0.15µs 32.3±0.11µs +0.31%
ops/text/yrs/remove 2.5±0.02µs 2.5±0.04µs -0.00%
update/parse with jwst/basic.bin 52.4±0.39µs 57.8±0.36µs +10.31%
update/parse with jwst/database.bin 43.1±0.15µs 43.3±0.20µs +0.46%
update/parse with jwst/large.bin 2.5±0.05ms 2.6±0.09ms +4.00%
update/parse with jwst/with-subdoc.bin 8.2±0.07µs 7.6±0.14µs -7.32%
update/parse with yrs/basic.bin 45.1±0.48µs 43.8±0.16µs -2.88%
update/parse with yrs/database.bin 35.3±0.15µs 34.6±0.22µs -1.98%
update/parse with yrs/large.bin 2.1±0.05ms 2.1±0.04ms -0.00%
update/parse with yrs/with-subdoc.bin 7.3±0.04µs 7.0±0.03µs -4.11%

@forehalo forehalo closed this Dec 26, 2023
@forehalo forehalo deleted the 61/blob-api branch December 26, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant