Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: init workspace api #542

Merged
merged 1 commit into from
Sep 27, 2023
Merged

feat: init workspace api #542

merged 1 commit into from
Sep 27, 2023

Conversation

darkskygit
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
octobase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 8:59am

@darkskygit darkskygit temporarily deployed to development September 27, 2023 08:59 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development September 27, 2023 08:59 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 53 lines in your changes are missing coverage. Please review.

Comparison is base (7d37ab5) 65.99% compared to head (2a677c1) 65.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #542      +/-   ##
==========================================
- Coverage   65.99%   65.75%   -0.25%     
==========================================
  Files         115      115              
  Lines       12626    12698      +72     
==========================================
+ Hits         8333     8349      +16     
- Misses       4293     4349      +56     
Files Coverage Δ
apps/keck/src/server/api/blocks/mod.rs 75.28% <100.00%> (+0.28%) ⬆️
apps/keck/src/server/api/doc.rs 93.10% <ø> (ø)
libs/jwst-storage/src/types.rs 0.00% <ø> (ø)
apps/keck/src/server/api/mod.rs 45.13% <0.00%> (-3.91%) ⬇️
libs/jwst-storage/src/storage/mod.rs 57.04% <5.26%> (-8.29%) ⬇️
apps/keck/src/server/api/blocks/workspace.rs 62.14% <40.90%> (-9.74%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

future::ready(x.is_ok())
})
.filter_map(|data| future::ready(data.ok()))
.flat_map(|buffer| iter(buffer))

Check warning

Code scanning / clippy

redundant closure

redundant closure
@github-actions
Copy link

Benchmark for Linux

Click to view benchmark
Test Base PR %
codec/jwst decode var_int (32 bit) 369.7±24.09µs 360.7±17.69µs -2.43%
codec/jwst decode var_uint (32 bit) 320.1±20.67µs 305.0±19.61µs -4.72%
codec/jwst decode var_uint (64 bit) 313.6±17.43µs 320.6±19.18µs +2.23%
codec/jwst encode var_int (32 bit) 486.3±21.96µs 458.1±26.95µs -5.80%
codec/jwst encode var_uint (32 bit) 349.5±25.22µs 337.7±19.48µs -3.38%
codec/jwst encode var_uint (64 bit) 336.0±18.88µs 344.7±23.63µs +2.59%
codec/lib0 decode var_int (64 bit) 340.1±14.88µs 321.8±35.12µs -5.38%
codec/lib0 decode var_uint (32 bit) 303.3±15.03µs 272.0±17.84µs -10.32%
codec/lib0 decode var_uint (64 bit) 292.9±15.34µs 282.5±18.76µs -3.55%
codec/lib0 encode var_int (64 bit) 492.6±24.56µs 443.8±30.26µs -9.91%
codec/lib0 encode var_uint (32 bit) 334.6±23.14µs 294.5±18.29µs -11.98%
codec/lib0 encode var_uint (64 bit) 329.1±18.90µs 323.2±15.66µs -1.79%
ops/array/jwst/insert 308.4±14.09µs 301.5±17.19µs -2.24%
ops/array/jwst/insert range 429.8±21.17µs 448.0±40.43µs +4.23%
ops/array/jwst/remove 189.4±12.12µs 193.6±11.82µs +2.22%
ops/array/yrs/insert 96.2±5.26µs 100.0±5.57µs +3.95%
ops/array/yrs/insert range 126.9±6.92µs 124.2±6.05µs -2.13%
ops/array/yrs/remove 103.6±5.66µs 101.7±5.42µs -1.83%
ops/text/jwst/insert 167.1±14.83µs 170.0±9.11µs +1.74%
ops/text/jwst/remove 3.7±0.16µs 3.8±0.18µs +2.70%
ops/text/yrs/insert 45.6±2.04µs 46.0±2.31µs +0.88%
ops/text/yrs/remove 2.5±0.14µs 2.6±0.14µs +4.00%
update/parse with jwst/basic.bin 85.5±5.32µs 80.6±4.93µs -5.73%
update/parse with jwst/database.bin 52.8±3.70µs 50.9±3.78µs -3.60%
update/parse with jwst/large.bin 4.3±0.19ms 4.0±0.18ms -6.98%
update/parse with jwst/with-subdoc.bin 11.4±0.66µs 10.4±0.60µs -8.77%
update/parse with yrs/basic.bin 51.0±2.30µs 50.4±4.32µs -1.18%
update/parse with yrs/database.bin 40.6±2.25µs 40.1±2.14µs -1.23%
update/parse with yrs/large.bin 2.7±0.13ms 2.6±0.15ms -3.70%
update/parse with yrs/with-subdoc.bin 7.9±0.59µs 6.4±0.41µs -18.99%

Benchmark for Windows

Click to view benchmark
Test Base PR %
codec/jwst decode var_int (32 bit) 458.8±26.77µs 433.1±18.76µs -5.60%
codec/jwst decode var_uint (32 bit) 407.5±35.01µs 398.3±18.10µs -2.26%
codec/jwst decode var_uint (64 bit) 407.4±16.71µs 421.4±29.04µs +3.44%
codec/jwst encode var_int (32 bit) 541.6±27.03µs 520.8±22.35µs -3.84%
codec/jwst encode var_uint (32 bit) 361.5±16.78µs 355.6±15.73µs -1.63%
codec/jwst encode var_uint (64 bit) 359.2±13.58µs 370.9±22.53µs +3.26%
codec/lib0 decode var_int (64 bit) 372.2±18.53µs 375.2±20.41µs +0.81%
codec/lib0 decode var_uint (32 bit) 314.2±14.82µs 313.8±19.67µs -0.13%
codec/lib0 decode var_uint (64 bit) 319.2±18.73µs 304.9±15.26µs -4.48%
codec/lib0 encode var_int (64 bit) 533.2±27.50µs 533.8±25.43µs +0.11%
codec/lib0 encode var_uint (32 bit) 361.0±11.82µs 354.6±17.69µs -1.77%
codec/lib0 encode var_uint (64 bit) 376.9±19.06µs 369.5±22.70µs -1.96%
ops/array/jwst/insert 392.1±9.81µs 404.9±21.68µs +3.26%
ops/array/jwst/insert range 538.7±15.83µs 528.5±26.17µs -1.89%
ops/array/jwst/remove 218.5±10.02µs 213.9±8.24µs -2.11%
ops/array/yrs/insert 141.1±7.22µs 136.7±4.95µs -3.12%
ops/array/yrs/insert range 187.9±6.32µs 184.7±7.25µs -1.70%
ops/array/yrs/remove 199.2±9.79µs 200.4±9.42µs +0.60%
ops/text/jwst/insert 232.8±8.82µs 224.1±9.19µs -3.74%
ops/text/jwst/remove 6.4±0.18µs 6.7±0.39µs +4.69%
ops/text/yrs/insert 58.0±2.72µs 58.3±2.56µs +0.52%
ops/text/yrs/remove 6.0±0.60µs 5.6±0.21µs -6.67%
update/parse with jwst/basic.bin 131.6±7.12µs 122.1±5.67µs -7.22%
update/parse with jwst/database.bin 95.0±2.46µs 95.9±4.20µs +0.95%
update/parse with jwst/large.bin 6.1±0.27ms 6.0±0.23ms -1.64%
update/parse with jwst/with-subdoc.bin 18.9±0.56µs 17.8±0.63µs -5.82%
update/parse with yrs/basic.bin 83.5±3.05µs 81.5±3.77µs -2.40%
update/parse with yrs/database.bin 67.1±3.53µs 64.0±2.34µs -4.62%
update/parse with yrs/large.bin 4.0±0.18ms 4.2±0.26ms +5.00%
update/parse with yrs/with-subdoc.bin 14.0±0.51µs 14.6±0.85µs +4.29%

@darkskygit darkskygit merged commit 0353d36 into master Sep 27, 2023
@darkskygit darkskygit deleted the darksky/init-workspace branch September 27, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant