Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): at menu position in split view #9500

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

Flrande
Copy link
Member

@Flrande Flrande commented Jan 3, 2025

No description provided.

@Flrande Flrande requested a review from a team as a code owner January 3, 2025 05:41
Copy link

graphite-app bot commented Jan 3, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@graphite-app graphite-app bot requested a review from forehalo January 3, 2025 05:41
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 46.23656% with 50 lines in your changes missing coverage. Please review.

Project coverage is 52.85%. Comparing base (b17dac2) to head (2074bda).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
.../blocks/src/root-block/widgets/linked-doc/index.ts 46.98% 44 Missing ⚠️
...ared/src/commands/selection/get-selection-rects.ts 50.00% 4 Missing ⚠️
.../src/root-block/widgets/keyboard-toolbar/config.ts 0.00% 1 Missing ⚠️
...blocks/src/root-block/widgets/slash-menu/config.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #9500   +/-   ##
=======================================
  Coverage   52.85%   52.85%           
=======================================
  Files        2151     2151           
  Lines       97024    96989   -35     
  Branches    16161    16154    -7     
=======================================
- Hits        51280    51264   -16     
+ Misses      44348    44330   -18     
+ Partials     1396     1395    -1     
Flag Coverage Δ
server-test 78.07% <ø> (ø)
unittest 32.44% <6.45%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Flrande Flrande added the merge label Jan 3, 2025
Copy link
Member Author

Flrande commented Jan 3, 2025

Merge activity

  • Jan 3, 6:53 AM EST: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 3, 7:20 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 3, 7:35 AM EST: A user merged this pull request with the Graphite merge queue.

@Flrande Flrande force-pushed the flrande/fix/pd-2129-0103 branch from 421446d to 2074bda Compare January 3, 2025 12:20
@graphite-app graphite-app bot merged commit 2074bda into canary Jan 3, 2025
61 checks passed
@graphite-app graphite-app bot deleted the flrande/fix/pd-2129-0103 branch January 3, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants