Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): job should not rely on doc collection directly #9488

Conversation

Saul-Mirone
Copy link
Contributor

No description provided.

@github-actions github-actions bot added test Related to test cases app:core labels Jan 2, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Saul-Mirone Saul-Mirone marked this pull request as ready for review January 2, 2025 10:14
@Saul-Mirone Saul-Mirone requested a review from a team as a code owner January 2, 2025 10:14
@Saul-Mirone Saul-Mirone changed the title refactor(editor): job should not rely on doc collection refactor(editor): job should not rely on doc collection directly Jan 2, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 50.97087% with 101 lines in your changes missing coverage. Please review.

Project coverage is 52.56%. Comparing base (f2906bc) to head (edb5e1d).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...ite/blocks/src/_common/transformers/middlewares.ts 74.57% 28 Missing and 2 partials ⚠️
...ksuite/blocks/src/_common/transformers/markdown.ts 0.00% 12 Missing ⚠️
...blocksuite/presets/_common/utils/markdown-utils.ts 0.00% 12 Missing ⚠️
blocksuite/blocks/src/_common/transformers/html.ts 0.00% 9 Missing ⚠️
...cks/src/root-block/edgeless/clipboard/clipboard.ts 0.00% 7 Missing ⚠️
blocksuite/blocks/src/_common/transformers/zip.ts 14.28% 6 Missing ⚠️
...e/framework/block-std/src/scope/block-std-scope.ts 0.00% 5 Missing ⚠️
...locks/src/root-block/edgeless/services/template.ts 0.00% 4 Missing ⚠️
...ite/blocks/src/_common/transformers/notion-html.ts 0.00% 3 Missing ⚠️
...locks/src/root-block/edgeless/utils/clone-utils.ts 0.00% 3 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9488      +/-   ##
==========================================
- Coverage   52.61%   52.56%   -0.06%     
==========================================
  Files        2151     2151              
  Lines       96935    96986      +51     
  Branches    16148    16147       -1     
==========================================
- Hits        51000    50978      -22     
- Misses      44522    44597      +75     
+ Partials     1413     1411       -2     
Flag Coverage Δ
server-test 78.07% <ø> (-0.07%) ⬇️
unittest 32.59% <42.71%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Jan 2, 2025

Merge activity

@Saul-Mirone Saul-Mirone force-pushed the 01-02-refactor_editor_job_should_not_rely_on_doc_collection branch from 0c73fe5 to edb5e1d Compare January 2, 2025 10:50
@graphite-app graphite-app bot merged commit edb5e1d into canary Jan 2, 2025
61 checks passed
@graphite-app graphite-app bot deleted the 01-02-refactor_editor_job_should_not_rely_on_doc_collection branch January 2, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants