Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): remove dndkit in split view #9487

Draft
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Jan 2, 2025

No description provided.

Copy link
Collaborator Author

pengx17 commented Jan 2, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 3.50877% with 55 lines in your changes missing coverage. Please review.

Project coverage is 52.87%. Comparing base (4457cb7) to head (3094aa8).

Files with missing lines Patch % Lines
...kages/frontend/component/src/ui/dnd/drop-target.ts 3.22% 30 Missing ⚠️
...ages/frontend/component/src/utils/shallow-equal.ts 0.00% 14 Missing ⚠️
packages/frontend/component/src/ui/dnd/monitor.tsx 8.33% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9487      +/-   ##
==========================================
- Coverage   52.91%   52.87%   -0.05%     
==========================================
  Files        2151     2153       +2     
  Lines       96989    97026      +37     
  Branches    16154    16165      +11     
==========================================
- Hits        51322    51302      -20     
- Misses      44300    44324      +24     
- Partials     1367     1400      +33     
Flag Coverage Δ
server-test 78.07% <ø> (-0.07%) ⬇️
unittest 32.48% <3.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 01-02-refactor_core_remove_dndkit_in_split_view branch 2 times, most recently from 8ecd7dd to 661cc4f Compare January 3, 2025 14:10
@pengx17 pengx17 force-pushed the 01-02-refactor_core_remove_dndkit_in_split_view branch from 661cc4f to 3094aa8 Compare January 3, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant