Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): too many digits after decimal point in table calculations #9471

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

OlegDev1
Copy link
Contributor

Fixes floating-point precision error, when using average, median, range functions

Changes

Average

Before:
Screenshot 2024-12-30 at 18 12 09
After:
Screenshot 2024-12-30 at 18 14 44

Median

Before:
Screenshot 2024-12-31 at 15 18 55
After:
Screenshot 2024-12-31 at 15 20 46

Range

Before:
Screenshot 2024-12-30 at 18 20 33
After:
Screenshot 2024-12-30 at 18 21 36

@OlegDev1 OlegDev1 requested a review from a team as a code owner December 31, 2024 14:39
@CLAassistant
Copy link

CLAassistant commented Dec 31, 2024

CLA assistant check
All committers have signed the CLA.

@graphite-app graphite-app bot requested a review from forehalo December 31, 2024 14:39
Copy link

graphite-app bot commented Dec 31, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, and happy new year!

@doodlewind doodlewind changed the title fix(database): too many digits after decimal point in table calculations fix(editor): too many digits after decimal point in table calculations Jan 1, 2025
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 52.58%. Comparing base (5e1d936) to head (8658c1a).
Report is 62 commits behind head on canary.

Files with missing lines Patch % Lines
...ite/affine/data-view/src/core/statistics/number.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9471      +/-   ##
==========================================
+ Coverage   51.51%   52.58%   +1.06%     
==========================================
  Files        2146     2151       +5     
  Lines       97063    96962     -101     
  Branches    16271    16154     -117     
==========================================
+ Hits        50003    50984     +981     
+ Misses      45682    44559    -1123     
- Partials     1378     1419      +41     
Flag Coverage Δ
server-test 78.14% <ø> (-0.18%) ⬇️
unittest 32.57% <0.00%> (+1.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

nx-cloud bot commented Jan 1, 2025

View your CI Pipeline Execution ↗ for commit 8658c1a.

Command Status Duration Result
nx build @affine/native -- --target x86_64-pc-w... ✅ Succeeded 4m 4s View ↗
nx build @affine/native -- --target x86_64-appl... ✅ Succeeded 1m 22s View ↗
nx build @affine/native -- --target aarch64-app... ✅ Succeeded 1m 23s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-01 09:31:51 UTC

@Brooooooklyn Brooooooklyn merged commit ade764b into toeverything:canary Jan 1, 2025
60 of 64 checks passed
@OlegDev1
Copy link
Contributor Author

OlegDev1 commented Jan 1, 2025

Thanks for the fix, and happy new year!

You are welcome! Happy new year to you too, wishing you a fantastic 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants