Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): can not close float bar by clicking editor blank area #9467

Closed
wants to merge 1 commit into from

Conversation

Flrande
Copy link
Member

@Flrande Flrande commented Dec 31, 2024

No description provided.

@Flrande Flrande requested a review from a team as a code owner December 31, 2024 10:06
@graphite-app graphite-app bot requested a review from forehalo December 31, 2024 10:06
Copy link

graphite-app bot commented Dec 31, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.62%. Comparing base (f64d62d) to head (8a3da57).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...k/widgets/page-dragging-area/page-dragging-area.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9467      +/-   ##
==========================================
+ Coverage   51.61%   51.62%   +0.01%     
==========================================
  Files        2154     2154              
  Lines       97044    97045       +1     
  Branches    16173    16174       +1     
==========================================
+ Hits        50089    50100      +11     
+ Misses      45628    45618      -10     
  Partials     1327     1327              
Flag Coverage Δ
server-test 78.07% <ø> (ø)
unittest 31.04% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Flrande Flrande closed this Dec 31, 2024
@Saul-Mirone Saul-Mirone deleted the flrande/fix/float-bar-1231 branch December 31, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant