Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(editor): remove jsx snapshot #9463

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

Saul-Mirone
Copy link
Contributor

No description provided.

Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Saul-Mirone Saul-Mirone marked this pull request as ready for review December 31, 2024 08:53
@Saul-Mirone Saul-Mirone requested a review from a team as a code owner December 31, 2024 08:53
@graphite-app graphite-app bot requested a review from forehalo December 31, 2024 08:53
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.60%. Comparing base (6c33eaa) to head (36c1b10).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9463      +/-   ##
==========================================
+ Coverage   51.61%   52.60%   +0.98%     
==========================================
  Files        2154     2151       -3     
  Lines       97043    96960      -83     
  Branches    16173    16154      -19     
==========================================
+ Hits        50088    51002     +914     
+ Misses      45628    44537    -1091     
- Partials     1327     1421      +94     
Flag Coverage Δ
server-test 78.07% <ø> (ø)
unittest 32.63% <100.00%> (+1.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Saul-Mirone Saul-Mirone force-pushed the 12-31-test_editor_remove_jsx_snapshot branch from 7d9a79d to 40930ba Compare December 31, 2024 09:08
Copy link

graphite-app bot commented Dec 31, 2024

Merge activity

  • Dec 31, 4:27 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 31, 5:11 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Desktop Test (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)').
  • Dec 31, 5:21 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 31, 5:40 AM EST: A user merged this pull request with the Graphite merge queue.

@Saul-Mirone Saul-Mirone force-pushed the 12-31-test_editor_remove_jsx_snapshot branch from 40930ba to a828b30 Compare December 31, 2024 09:42
@github-actions github-actions bot added the test Related to test cases label Dec 31, 2024
@Saul-Mirone Saul-Mirone force-pushed the 12-31-test_editor_remove_jsx_snapshot branch from a828b30 to 5ac6c60 Compare December 31, 2024 09:45
Saul-Mirone added a commit that referenced this pull request Dec 31, 2024
@Saul-Mirone Saul-Mirone force-pushed the 12-31-test_editor_remove_jsx_snapshot branch from 5ac6c60 to 47982e9 Compare December 31, 2024 09:47
Saul-Mirone added a commit that referenced this pull request Dec 31, 2024
@Saul-Mirone Saul-Mirone force-pushed the 12-31-test_editor_remove_jsx_snapshot branch from 47982e9 to cf65777 Compare December 31, 2024 09:55
@Saul-Mirone Saul-Mirone force-pushed the 12-31-test_editor_remove_jsx_snapshot branch from cf65777 to 36c1b10 Compare December 31, 2024 10:27
@graphite-app graphite-app bot merged commit 36c1b10 into canary Dec 31, 2024
61 checks passed
@graphite-app graphite-app bot deleted the 12-31-test_editor_remove_jsx_snapshot branch December 31, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants