Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): wrong style of mindmap in dark mode #9462

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Dec 31, 2024

🎥 Video uploaded on Graphite:

Copy link
Contributor Author

fundon commented Dec 31, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fundon fundon marked this pull request as ready for review December 31, 2024 08:40
@fundon fundon requested a review from a team as a code owner December 31, 2024 08:40
@graphite-app graphite-app bot requested a review from forehalo December 31, 2024 08:40
@fundon fundon marked this pull request as draft December 31, 2024 08:46
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.59%. Comparing base (36c1b10) to head (d97c4b5).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...cksuite/affine/model/src/elements/mindmap/style.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9462      +/-   ##
==========================================
- Coverage   52.60%   52.59%   -0.01%     
==========================================
  Files        2151     2151              
  Lines       96960    96961       +1     
  Branches    16154    16154              
==========================================
- Hits        51002    51000       -2     
- Misses      44537    44549      +12     
+ Partials     1421     1412       -9     
Flag Coverage Δ
server-test 78.07% <ø> (ø)
unittest 32.62% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the fundon/12_31_fix_colors_for_mindmap_style_2 branch from b599c04 to 6888842 Compare December 31, 2024 09:58
@fundon fundon changed the title fix(editor): colors in mindmap style 2 refactor(core): use color type for shadow colors Dec 31, 2024
@fundon fundon changed the title refactor(core): use color type for shadow colors fix(editor): Dec 31, 2024
@fundon fundon changed the title fix(editor): fix(editor): mindmap wrong style in dark mode Dec 31, 2024
@fundon fundon force-pushed the fundon/12_31_fix_colors_for_mindmap_style_2 branch from 6888842 to 7a4926b Compare December 31, 2024 10:09
@fundon fundon changed the title fix(editor): mindmap wrong style in dark mode fix(editor): wrong style of mindmap in dark mode Dec 31, 2024
@fundon fundon changed the title fix(editor): wrong style of mindmap in dark mode fix(editor): wrong style of mindmap in dark mode Dec 31, 2024
@fundon fundon marked this pull request as ready for review December 31, 2024 10:13
@fundon fundon requested a review from doouding December 31, 2024 10:16
@fundon fundon force-pushed the fundon/12_31_fix_colors_for_mindmap_style_2 branch 2 times, most recently from ed9df5a to 5cdd7d7 Compare December 31, 2024 10:39
Copy link

graphite-app bot commented Dec 31, 2024

Merge activity

@Saul-Mirone Saul-Mirone force-pushed the fundon/12_31_fix_colors_for_mindmap_style_2 branch from 5cdd7d7 to d97c4b5 Compare December 31, 2024 11:54
@graphite-app graphite-app bot merged commit d97c4b5 into canary Dec 31, 2024
61 checks passed
@graphite-app graphite-app bot deleted the fundon/12_31_fix_colors_for_mindmap_style_2 branch December 31, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants