Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): extract frame title widget #9458

Merged

Conversation

Saul-Mirone
Copy link
Contributor

No description provided.

@Saul-Mirone Saul-Mirone marked this pull request as ready for review December 31, 2024 07:03
@Saul-Mirone Saul-Mirone requested a review from a team as a code owner December 31, 2024 07:03
@graphite-app graphite-app bot requested a review from forehalo December 31, 2024 07:03
Copy link
Contributor Author

Saul-Mirone commented Dec 31, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Saul-Mirone Saul-Mirone force-pushed the 12-31-refactor_editor_extract_color_picker_component branch from 6b127ab to 49112e7 Compare December 31, 2024 07:06
@Saul-Mirone Saul-Mirone force-pushed the 12-31-refactor_editor_extract_frame_title_component branch from 6455522 to 58d7e24 Compare December 31, 2024 07:07
@Saul-Mirone Saul-Mirone changed the title refactor(editor): extract frame title component refactor(editor): extract frame title widget Dec 31, 2024
@Saul-Mirone Saul-Mirone changed the base branch from 12-31-refactor_editor_extract_color_picker_component to graphite-base/9458 December 31, 2024 07:21
@Saul-Mirone Saul-Mirone force-pushed the 12-31-refactor_editor_extract_frame_title_component branch from 58d7e24 to 2cc29f3 Compare December 31, 2024 07:39
@Saul-Mirone Saul-Mirone changed the base branch from graphite-base/9458 to canary December 31, 2024 07:40
@Saul-Mirone Saul-Mirone force-pushed the 12-31-refactor_editor_extract_frame_title_component branch from 2cc29f3 to 80ad5e2 Compare December 31, 2024 07:40
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.61%. Comparing base (f64d62d) to head (6c33eaa).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...suite/affine/widget-frame-title/src/frame-title.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9458      +/-   ##
==========================================
- Coverage   51.61%   51.61%   -0.01%     
==========================================
  Files        2154     2154              
  Lines       97044    97043       -1     
  Branches    16173    16173              
==========================================
- Hits        50089    50088       -1     
  Misses      45628    45628              
  Partials     1327     1327              
Flag Coverage Δ
server-test 78.07% <ø> (ø)
unittest 31.04% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Dec 31, 2024

Merge activity

@Saul-Mirone Saul-Mirone force-pushed the 12-31-refactor_editor_extract_frame_title_component branch from 80ad5e2 to 6c33eaa Compare December 31, 2024 10:12
@graphite-app graphite-app bot merged commit 6c33eaa into canary Dec 31, 2024
61 checks passed
@graphite-app graphite-app bot deleted the 12-31-refactor_editor_extract_frame_title_component branch December 31, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants