Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): missing resource files in exported snapshot zip #9450

Conversation

Saul-Mirone
Copy link
Contributor

@Saul-Mirone Saul-Mirone commented Dec 31, 2024

Closes: BS-2280

@Saul-Mirone Saul-Mirone marked this pull request as ready for review December 31, 2024 05:00
@Saul-Mirone Saul-Mirone requested a review from a team as a code owner December 31, 2024 05:00
@graphite-app graphite-app bot requested a review from forehalo December 31, 2024 05:00
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 51.66%. Comparing base (7aba836) to head (0f03c3f).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
blocksuite/blocks/src/_common/transformers/zip.ts 0.00% 7 Missing ⚠️
...el/src/blocks/attachment/attachment-transformer.ts 0.00% 6 Missing ⚠️
...affine/model/src/blocks/image/image-transformer.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9450      +/-   ##
==========================================
+ Coverage   51.64%   51.66%   +0.01%     
==========================================
  Files        2152     2152              
  Lines       97029    97044      +15     
  Branches    16207    16210       +3     
==========================================
+ Hits        50113    50138      +25     
+ Misses      45599    45587      -12     
- Partials     1317     1319       +2     
Flag Coverage Δ
server-test 78.14% <ø> (+0.06%) ⬆️
unittest 31.02% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Dec 31, 2024

Merge activity

@Saul-Mirone Saul-Mirone force-pushed the 12-31-fix_editor_missing_resource_files_in_exported_snapshot_zip branch from bdcef2c to 0f03c3f Compare December 31, 2024 05:13
@graphite-app graphite-app bot merged commit 0f03c3f into canary Dec 31, 2024
61 checks passed
@graphite-app graphite-app bot deleted the 12-31-fix_editor_missing_resource_files_in_exported_snapshot_zip branch December 31, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants