Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shortcut of zooming to selection #9447

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

doouding
Copy link
Member

@doouding doouding commented Dec 31, 2024

Changed

  • change edgeless shortcut cmd + 0, cmd + 1 to alt + 0, alt + 1
  • add new shortcut alt + 2 to zoom to currently selected elements

Copy link
Member Author

doouding commented Dec 31, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 22 lines in your changes missing coverage. Please review.

Project coverage is 52.90%. Comparing base (30a181d) to head (a4e94ab).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
blocksuite/framework/block-std/src/gfx/viewport.ts 14.28% 6 Missing and 6 partials ⚠️
...locks/src/root-block/edgeless/edgeless-keyboard.ts 16.66% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9447      +/-   ##
==========================================
+ Coverage   52.88%   52.90%   +0.01%     
==========================================
  Files        2152     2152              
  Lines       96973    96995      +22     
  Branches    16144    16152       +8     
==========================================
+ Hits        51288    51312      +24     
+ Misses      44296    44288       -8     
- Partials     1389     1395       +6     
Flag Coverage Δ
server-test 78.14% <ø> (+0.06%) ⬆️
unittest 32.47% <7.69%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

perfsee bot commented Dec 31, 2024

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                        EntryPoint: app                        @@
##                     canary …_to_selection                 +/- ##
===================================================================
< Bundle              24.3 MB        24.3 MB    +23.7 kB(+0.10%)   
< Initial JS          10.6 MB        10.7 MB      +16 kB(+0.15%)   
= Initial CSS          260 kB         260 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   91             91                       
= Chunks                   89             89                       
< Packages                269            270                  +1   
< Duplicates                3              4                  +1   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@doouding doouding marked this pull request as ready for review January 3, 2025 03:41
@doouding doouding requested a review from a team as a code owner January 3, 2025 03:41
@graphite-app graphite-app bot requested review from forehalo, pengx17, EYHN, CatsJuice and JimmFly and removed request for forehalo and EYHN January 3, 2025 03:41
@doouding doouding changed the title feat: add shortcut to zoom to selection feat: add shortcut of zooming to selection Jan 3, 2025
Copy link

graphite-app bot commented Jan 3, 2025

Merge activity

### Changed
- change edgeless shortcut `cmd + 0`, `cmd + 1` to `alt + 0`, `alt + 1`
- add new shortcut `alt + 2` to zoom to currently selected elements
@doouding doouding force-pushed the 12-31-feat_add_shortcut_to_zoom_to_selection branch from cf28270 to a4e94ab Compare January 3, 2025 03:57
@graphite-app graphite-app bot merged commit a4e94ab into canary Jan 3, 2025
61 checks passed
@graphite-app graphite-app bot deleted the 12-31-feat_add_shortcut_to_zoom_to_selection branch January 3, 2025 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants