Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): page history api fetch issue #9440

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Dec 30, 2024

No description provided.

Copy link
Collaborator Author

pengx17 commented Dec 30, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pengx17 pengx17 marked this pull request as ready for review December 30, 2024 16:38
@pengx17 pengx17 requested a review from Brooooooklyn December 30, 2024 16:39
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.71%. Comparing base (8463e4d) to head (d04b5d6).
Report is 12 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9440      +/-   ##
==========================================
+ Coverage   51.49%   51.71%   +0.22%     
==========================================
  Files        2150     2152       +2     
  Lines       97006    97009       +3     
  Branches    16201    16205       +4     
==========================================
+ Hits        49949    50169     +220     
+ Misses      45671    45092     -579     
- Partials     1386     1748     +362     
Flag Coverage Δ
server-test 78.14% <ø> (ø)
unittest 31.12% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Dec 31, 2024

Merge activity

@forehalo forehalo merged commit 6883cc2 into canary Dec 31, 2024
64 checks passed
@forehalo forehalo deleted the 12-31-fix_electron_page_history_api_fetch_issue branch December 31, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants