Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): simplify tsconfig #9439

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

Saul-Mirone
Copy link
Contributor

No description provided.

@Saul-Mirone Saul-Mirone marked this pull request as ready for review December 30, 2024 14:25
@Saul-Mirone Saul-Mirone requested a review from a team as a code owner December 30, 2024 14:25
@graphite-app graphite-app bot requested a review from forehalo December 30, 2024 14:25
Copy link
Contributor Author

Saul-Mirone commented Dec 30, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Base automatically changed from 12-30-fix_editor_missing_dependencies to canary December 30, 2024 14:25
Copy link

graphite-app bot commented Dec 30, 2024

Merge activity

  • Dec 30, 9:26 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 30, 9:43 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Desktop Test (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)').
  • Dec 30, 11:12 AM EST: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 30, 11:12 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 30, 11:29 AM EST: A user merged this pull request with the Graphite merge queue.

Saul-Mirone added a commit that referenced this pull request Dec 30, 2024
@Saul-Mirone Saul-Mirone force-pushed the 12-30-refactor_editor_simplify_tsconfig branch from e076c9e to 4275ba9 Compare December 30, 2024 14:27
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.68%. Comparing base (8d269c8) to head (397a483).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #9439   +/-   ##
=======================================
  Coverage   51.67%   51.68%           
=======================================
  Files        2152     2152           
  Lines       97009    97009           
  Branches    16205    16205           
=======================================
+ Hits        50133    50135    +2     
+ Misses      45513    45511    -2     
  Partials     1363     1363           
Flag Coverage Δ
server-test 78.14% <ø> (ø)
unittest 31.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Saul-Mirone Saul-Mirone force-pushed the 12-30-refactor_editor_simplify_tsconfig branch from 4275ba9 to 397a483 Compare December 30, 2024 16:15
@graphite-app graphite-app bot merged commit 397a483 into canary Dec 30, 2024
61 checks passed
@graphite-app graphite-app bot deleted the 12-30-refactor_editor_simplify_tsconfig branch December 30, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants