perf(editor): reduce per frame viewport dom ops #9431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #9431 +/- ##
=======================================
Coverage 51.46% 51.46%
=======================================
Files 2150 2150
Lines 97006 97007 +1
Branches 16201 16206 +5
=======================================
+ Hits 49927 49928 +1
Misses 45693 45693
Partials 1386 1386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Saul-Mirone
approved these changes
Dec 30, 2024
Merge activity
|
doodlewind
added a commit
that referenced
this pull request
Dec 30, 2024
Currently when panning / zooming on whiteboard, both position and transform of each block component are updated per frame. The positioning part lead to heavy layout costs, which can be reduced. Before (~35fps):  After (~50fps):  Tested environment: TibetTravel templet, Windows 11, i5-1130G7 1.1GHz
doodlewind
force-pushed
the
doodl/edgeless
branch
from
dd2c8d5 to
dbfd47a
Compare
Currently when panning / zooming on whiteboard, both position and transform of each block component are updated per frame. The positioning part lead to heavy layout costs, which can be reduced. Before (~35fps):  After (~50fps):  Tested environment: TibetTravel templet, Windows 11, i5-1130G7 1.1GHz
doodlewind
force-pushed
the
doodl/edgeless
branch
from
dbfd47a to
d4053a3
Compare
|
nb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when panning / zooming on whiteboard, both position and transform of each block component are updated per frame. The positioning part lead to heavy layout costs, which can be reduced.
Before (~35fps):
After (~50fps):
Tested environment: TibetTravel templet, Windows 11, i5-1130G7 1.1GHz