Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): use spec builder #9424

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

Saul-Mirone
Copy link
Contributor

No description provided.

Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 51.43%. Comparing base (4fee0e2) to head (b66a64b).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...suite/affine/shared/src/utils/spec/spec-builder.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9424      +/-   ##
==========================================
- Coverage   51.46%   51.43%   -0.04%     
==========================================
  Files        2150     2150              
  Lines       97004    97004              
  Branches    16201    16200       -1     
==========================================
- Hits        49926    49890      -36     
- Misses      45695    45733      +38     
+ Partials     1383     1381       -2     
Flag Coverage Δ
server-test 78.07% <ø> (ø)
unittest 30.88% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Saul-Mirone Saul-Mirone force-pushed the 12-30-refactor_editor_use_spec_builder branch 2 times, most recently from 29dbd06 to 48c1ff1 Compare December 30, 2024 07:11
@Saul-Mirone Saul-Mirone marked this pull request as ready for review December 30, 2024 07:22
@Saul-Mirone Saul-Mirone requested a review from a team as a code owner December 30, 2024 07:22
@graphite-app graphite-app bot requested review from forehalo, pengx17, JimmFly, EYHN and CatsJuice and removed request for forehalo December 30, 2024 07:22
Copy link

graphite-app bot commented Dec 30, 2024

Merge activity

@Saul-Mirone Saul-Mirone force-pushed the 12-30-refactor_editor_use_spec_builder branch 2 times, most recently from a647fcf to 87ba0ae Compare December 30, 2024 07:59
@Saul-Mirone Saul-Mirone force-pushed the 12-30-refactor_editor_use_spec_builder branch from 87ba0ae to b66a64b Compare December 30, 2024 08:43
@graphite-app graphite-app bot merged commit b66a64b into canary Dec 30, 2024
61 checks passed
@graphite-app graphite-app bot deleted the 12-30-refactor_editor_use_spec_builder branch December 30, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants