Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): extract attachment block #9308

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

Saul-Mirone
Copy link
Contributor

No description provided.

Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Saul-Mirone Saul-Mirone marked this pull request as ready for review December 25, 2024 12:00
@Saul-Mirone Saul-Mirone requested a review from a team as a code owner December 25, 2024 12:00
@graphite-app graphite-app bot requested a review from forehalo December 25, 2024 12:00
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 19.44444% with 29 lines in your changes missing coverage. Please review.

Project coverage is 51.89%. Comparing base (d8bc145) to head (ebd9775).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
blocksuite/affine/block-attachment/src/utils.ts 14.81% 23 Missing ⚠️
.../block-attachment/src/attachment-edgeless-block.ts 0.00% 4 Missing ⚠️
.../affine/block-attachment/src/attachment-service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #9308   +/-   ##
=======================================
  Coverage   51.89%   51.89%           
=======================================
  Files        2148     2149    +1     
  Lines       97411    97416    +5     
  Branches    16272    16274    +2     
=======================================
+ Hits        50548    50553    +5     
- Misses      45550    45580   +30     
+ Partials     1313     1283   -30     
Flag Coverage Δ
server-test 78.17% <ø> (ø)
unittest 30.97% <8.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Dec 25, 2024

Merge activity

@Saul-Mirone Saul-Mirone force-pushed the 12-25-refactor_editor_extract_attachment_block branch from 1cfb58a to ebd9775 Compare December 25, 2024 12:20
@graphite-app graphite-app bot merged commit ebd9775 into canary Dec 25, 2024
60 checks passed
@graphite-app graphite-app bot deleted the 12-25-refactor_editor_extract_attachment_block branch December 25, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants