Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add pdf embed preview feature flag #9307

Merged
merged 1 commit into from
Dec 26, 2024
Merged

feat(core): add pdf embed preview feature flag #9307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/frontend/core/src/components/blocksuite/block-suite-editor/lit-adaper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import type {
} from '@affine/core/modules/doc-info/types';
import { EditorService } from '@affine/core/modules/editor';
import { EditorSettingService } from '@affine/core/modules/editor-setting';
import { FeatureFlagService } from '@affine/core/modules/feature-flag';
import { JournalService } from '@affine/core/modules/journal';
import { toURLSearchParams } from '@affine/core/modules/navigation';
import { PeekViewService } from '@affine/core/modules/peek-view/services/peek-view';
Expand Down Expand Up @@ -97,12 +98,14 @@ const usePatchSpecs = (shared: boolean, mode: DocMode) => {
docsService,
editorService,
workspaceService,
featureFlagService,
} = useServices({
PeekViewService,
DocService,
DocsService,
WorkspaceService,
EditorService,
FeatureFlagService,
});
const framework = useFramework();
const referenceRenderer: ReferenceReactRenderer = useMemo(() => {
Expand Down Expand Up @@ -149,7 +152,11 @@ const usePatchSpecs = (shared: boolean, mode: DocMode) => {
let patched = specs.concat(
patchReferenceRenderer(reactToLit, referenceRenderer)
);
patched = patched.concat(patchForAttachmentEmbedViews(reactToLit));

if (featureFlagService.flags.enable_pdf_embed_preview.value) {
patched = patched.concat(patchForAttachmentEmbedViews(reactToLit));
}

patched = patched.concat(patchNotificationService(confirmModal));
patched = patched.concat(patchPeekViewService(peekViewService));
patched = patched.concat(patchEdgelessClipboard());
Expand Down Expand Up @@ -178,6 +185,7 @@ const usePatchSpecs = (shared: boolean, mode: DocMode) => {
referenceRenderer,
shared,
specs,
featureFlagService,
]);

return [
Expand Down
11 changes: 10 additions & 1 deletion packages/frontend/core/src/modules/feature-flag/constant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,16 @@ export const AFFINE_FLAGS = {
configurable: isMobile,
defaultState: false,
},
enable_pdf_embed_preview: {
category: 'affine',
displayName:
'com.affine.settings.workspace.experimental-features.enable-pdf-embed-preview.name',
description:
'com.affine.settings.workspace.experimental-features.enable-pdf-embed-preview.description',
configurable: !isMobile,
defaultState: false,
},
} satisfies { [key in string]: FlagInfo };

// eslint-disable-next-line no-redeclare
// oxlint-disable-next-line no-redeclare
export type AFFINE_FLAGS = typeof AFFINE_FLAGS;
2 changes: 2 additions & 0 deletions packages/frontend/i18n/src/resources/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1324,6 +1324,8 @@
"com.affine.settings.workspace.experimental-features.enable-multiple-cloud-servers.description": "Once enabled, users can connect to selfhosted cloud servers.",
"com.affine.settings.workspace.experimental-features.enable-mobile-edgeless-editing.name": "Enable Edgeless Editing",
"com.affine.settings.workspace.experimental-features.enable-mobile-edgeless-editing.description": "Once enabled, users can edit edgeless canvas.",
"com.affine.settings.workspace.experimental-features.enable-pdf-embed-preview.name": "PDF embed preview",
"com.affine.settings.workspace.experimental-features.enable-pdf-embed-preview.description": "Once enabled, you can preview PDF in embed view.",
"com.affine.settings.workspace.not-owner": "Only an owner can edit the workspace avatar and name. Changes will be shown for everyone.",
"com.affine.settings.workspace.preferences": "Preference",
"com.affine.settings.workspace.billing": "Billing",
Expand Down
Loading