test(core): add tests for card view with edgeless mode link #8887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
L-Sun
added
merge
blocked
Graphite App
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f7d2088. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #8887 +/- ##
==========================================
- Coverage 64.64% 64.60% -0.05%
==========================================
Files 669 669
Lines 37428 37428
Branches 3626 3626
==========================================
- Hits 24197 24179 -18
- Misses 12857 12875 +18
Partials 374 374
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
L-Sun
changed the title
L-Sun
added a commit
to toeverything/blocksuite
that referenced
this pull request
Nov 22, 2024
…#8790) Close [BS-1907](https://linear.app/affine-design/issue/BS-1907/mode=edgeless的cardview转成embed，丢失了mode信息) This PR fixed the reference information is missing during edgeless card view conversion. The test will be added to AFFiNE side toeverything/AFFiNE#8887
L-Sun
force-pushed
the
l-sun/test/viewport-fitting-of-synced-edgeless-doc
branch
from
72d5b7b to
8f8bd76
Compare
L-Sun
force-pushed
the
l-sun/test/viewport-fitting-of-synced-edgeless-doc
branch
from
8f8bd76 to
342c68a
Compare
L-Sun
force-pushed
the
l-sun/test/viewport-fitting-of-synced-edgeless-doc
branch
from
342c68a to
f6fc72d
Compare
doodlewind
approved these changes
Dec 4, 2024
Merge activity
|
Close [BS-1881](https://linear.app/affine-design/issue/BS-1881/page内的edgeless-embed-缩放和坐标定位不太对), [BS-1907](https://linear.app/affine-design/issue/BS-1907/mode=edgeless的cardview转成embed，丢失了mode信息), related PR toeverything/blocksuite#8785, toeverything/blocksuite#8790 This PR adds a test for the fit-to-content feature of the viewport for the embed doc block in edgeless mode.
L-Sun
force-pushed
the
l-sun/test/viewport-fitting-of-synced-edgeless-doc
branch
from
f6fc72d to
f7d2088
Compare
graphite-app
bot
deleted the
l-sun/test/viewport-fitting-of-synced-edgeless-doc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close BS-1881, BS-1907, related PR toeverything/blocksuite#8785, toeverything/blocksuite#8790
This PR adds a test for the fit-to-content feature of the viewport for the embed doc block in edgeless mode.