Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): pdf viewer supports fit to page #8812

Open
wants to merge 1 commit into
base: fundon/11_02_pdf_embed_view
Choose a base branch
from

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Nov 13, 2024

What's Changed

  • fits to page by default
  • supports rendering pages of different sizes
Screen.Recording.2024-11-17.at.01.39.54.mov

Copy link

graphite-app bot commented Nov 13, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

fundon commented Nov 13, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fundon fundon marked this pull request as ready for review November 13, 2024 23:19
@fundon fundon force-pushed the fundon/11_14_pdf_viewer_supports_fit_to_page branch from a72bac1 to 3c2540a Compare November 13, 2024 23:20
@fundon fundon force-pushed the fundon/11_14_pdf_viewer_supports_fit_to_page branch from 3c2540a to bc9b535 Compare November 13, 2024 23:26
Copy link

nx-cloud bot commented Nov 13, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8ee0296. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.66%. Comparing base (bec5e53) to head (8ee0296).

Additional details and impacted files
@@                       Coverage Diff                       @@
##           fundon/11_02_pdf_embed_view    #8812      +/-   ##
===============================================================
- Coverage                        65.71%   65.66%   -0.06%     
===============================================================
  Files                              709      707       -2     
  Lines                            40578    40569       -9     
  Branches                          3906     3906              
===============================================================
- Hits                             26665    26638      -27     
- Misses                           13496    13513      +17     
- Partials                           417      418       +1     
Flag Coverage Δ
server-test 77.58% <ø> (-0.07%) ⬇️
unittest 36.04% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the fundon/11_14_pdf_viewer_supports_fit_to_page branch from bc9b535 to e459069 Compare November 15, 2024 23:29
@fundon fundon changed the base branch from canary to fundon/11_02_pdf_embed_view November 15, 2024 23:29
@fundon fundon force-pushed the fundon/11_14_pdf_viewer_supports_fit_to_page branch from e459069 to 3214835 Compare November 16, 2024 17:38
@fundon fundon force-pushed the fundon/11_14_pdf_viewer_supports_fit_to_page branch from 3214835 to e6082d0 Compare November 16, 2024 18:09
@fundon fundon force-pushed the fundon/11_14_pdf_viewer_supports_fit_to_page branch from c25d2d4 to cbc34f1 Compare November 20, 2024 07:35
@fundon fundon force-pushed the fundon/11_14_pdf_viewer_supports_fit_to_page branch from cbc34f1 to 12746b4 Compare November 20, 2024 08:21
@fundon fundon force-pushed the fundon/11_02_pdf_embed_view branch from 3a018ce to dedec70 Compare December 10, 2024 01:45
@fundon fundon force-pushed the fundon/11_14_pdf_viewer_supports_fit_to_page branch from 12746b4 to 1fb595d Compare December 10, 2024 01:45
@fundon fundon force-pushed the fundon/11_02_pdf_embed_view branch from dedec70 to cff7d0c Compare December 10, 2024 01:51
@fundon fundon force-pushed the fundon/11_14_pdf_viewer_supports_fit_to_page branch from 1fb595d to cc230ea Compare December 10, 2024 01:51
@fundon fundon force-pushed the fundon/11_02_pdf_embed_view branch from cff7d0c to 43d907c Compare December 10, 2024 02:15
@fundon fundon force-pushed the fundon/11_14_pdf_viewer_supports_fit_to_page branch from cc230ea to 6978e89 Compare December 10, 2024 02:16
@fundon fundon force-pushed the fundon/11_02_pdf_embed_view branch from 43d907c to bec5e53 Compare December 10, 2024 02:58
@fundon fundon force-pushed the fundon/11_14_pdf_viewer_supports_fit_to_page branch from 6978e89 to 481ad7d Compare December 10, 2024 02:58
@fundon fundon changed the title feat: pdf viewer supports fit to page feat(core): pdf viewer supports fit to page Dec 10, 2024
@fundon fundon force-pushed the fundon/11_14_pdf_viewer_supports_fit_to_page branch from 481ad7d to 8ee0296 Compare December 10, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants