-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): pdf viewer supports fit to page #8812
base: fundon/11_02_pdf_embed_view
Are you sure you want to change the base?
feat(core): pdf viewer supports fit to page #8812
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
packages/frontend/core/src/components/attachment-viewer/pdf-viewer.tsx
Outdated
Show resolved
Hide resolved
a72bac1
to
3c2540a
Compare
3c2540a
to
bc9b535
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8ee0296. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fundon/11_02_pdf_embed_view #8812 +/- ##
===============================================================
- Coverage 65.71% 65.66% -0.06%
===============================================================
Files 709 707 -2
Lines 40578 40569 -9
Branches 3906 3906
===============================================================
- Hits 26665 26638 -27
- Misses 13496 13513 +17
- Partials 417 418 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
packages/frontend/core/src/components/attachment-viewer/pdf-viewer.tsx
Outdated
Show resolved
Hide resolved
bc9b535
to
e459069
Compare
e459069
to
3214835
Compare
3214835
to
e6082d0
Compare
c25d2d4
to
cbc34f1
Compare
cbc34f1
to
12746b4
Compare
3a018ce
to
dedec70
Compare
12746b4
to
1fb595d
Compare
dedec70
to
cff7d0c
Compare
1fb595d
to
cc230ea
Compare
cff7d0c
to
43d907c
Compare
cc230ea
to
6978e89
Compare
43d907c
to
bec5e53
Compare
6978e89
to
481ad7d
Compare
481ad7d
to
8ee0296
Compare
What's Changed
Screen.Recording.2024-11-17.at.01.39.54.mov