Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mobile): new journal date-picker #8757

Merged
merged 1 commit into from
Nov 11, 2024
Merged

feat(mobile): new journal date-picker #8757

merged 1 commit into from
Nov 11, 2024

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Nov 9, 2024 •
edited
Loading

close AF-1649

🎥 Video uploaded on Graphite:

@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 9, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@CatsJuice Graphite App
Copy link
Member Author

CatsJuice commented Nov 9, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

@CatsJuice CatsJuice mentioned this pull request Nov 9, 2024
Merged
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 9, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 50a04f6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Nov 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.25%. Comparing base (9239eed) to head (50a04f6).
Report is 1 commits behind head on canary.

Additional details and impacted files 
@@            Coverage Diff             @@
##           canary    #8757      +/-   ##
==========================================
- Coverage   70.88%   70.25%   -0.63%     
==========================================
  Files         549      549              
  Lines       33890    33890              
  Branches     3080     3042      -38     
==========================================
- Hits        24023    23811     -212     
- Misses       9494     9709     +215     
+ Partials      373      370       -3
Flag Coverage Δ
server-test 77.18% <ø> (-0.72%) ⬇️
unittest 45.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice force-pushed the catsjuice/feat/mobile-journal-entrance branch from 5c1cbae to 1f7ff36 Compare November 10, 2024 01:43
@CatsJuice CatsJuice force-pushed the catsjuice/feat/mobile-journal-date-picker branch from 2632bf8 to a702585 Compare November 10, 2024 01:43
@CatsJuice CatsJuice force-pushed the catsjuice/feat/mobile-journal-date-picker branch from a702585 to dae2c51 Compare November 11, 2024 01:30
@EYHN EYHN changed the base branch from catsjuice/feat/mobile-journal-entrance to graphite-base/8757 November 11, 2024 04:26
@EYHN EYHN force-pushed the graphite-base/8757 branch from 1f7ff36 to 7bdad2d Compare November 11, 2024 04:42
@EYHN EYHN force-pushed the catsjuice/feat/mobile-journal-date-picker branch from dae2c51 to 7903bed Compare November 11, 2024 04:42
@EYHN EYHN changed the base branch from graphite-base/8757 to canary November 11, 2024 04:43
@EYHN EYHN force-pushed the catsjuice/feat/mobile-journal-date-picker branch from 7903bed to a4a3a17 Compare November 11, 2024 04:43
@CatsJuice CatsJuice force-pushed the catsjuice/feat/mobile-journal-date-picker branch from a4a3a17 to 8cc98be Compare November 11, 2024 08:49
@CatsJuice CatsJuice mentioned this pull request Nov 11, 2024
Merged
@CatsJuice CatsJuice marked this pull request as ready for review November 11, 2024 08:50
@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 11, 2024 •
edited
Loading

Merge activity

@CatsJuice CatsJuice force-pushed the catsjuice/feat/mobile-journal-date-picker branch from 8cc98be to 50a04f6 Compare November 11, 2024 09:31
@graphite-app graphite-app bot merged commit 50a04f6 into canary Nov 11, 2024
46 checks passed
@graphite-app graphite-app bot deleted the catsjuice/feat/mobile-journal-date-picker branch November 11, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pengx17 pengx17 pengx17 approved these changes

@forehalo forehalo Awaiting requested review from forehalo

@EYHN EYHN Awaiting requested review from EYHN

@JimmFly JimmFly Awaiting requested review from JimmFly

Assignees
No one assigned
Labels
app:core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CatsJuice @pengx17 @EYHN