Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mobile): disable some toolbar widgets for mobile #8742

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

L-Sun
Copy link
Contributor

@L-Sun L-Sun commented Nov 8, 2024

This PR disable some toolbar widgets on mobile. Close BS-1730

Copy link

graphite-app bot commented Nov 8, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

L-Sun commented Nov 8, 2024

Copy link

nx-cloud bot commented Nov 8, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1284f33. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.26%. Comparing base (39c6505) to head (1284f33).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #8742   +/-   ##
=======================================
  Coverage   70.26%   70.26%           
=======================================
  Files         549      549           
  Lines       33890    33890           
  Branches     3042     3042           
=======================================
  Hits        23813    23813           
  Misses       9707     9707           
  Partials      370      370           
Flag Coverage Δ
server-test 77.18% <ø> (ø)
unittest 45.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@L-Sun L-Sun force-pushed the l-sun/feat/mobile-linked-doc-widget branch from 559fc7c to 4ccd3a1 Compare November 8, 2024 08:35
@L-Sun L-Sun force-pushed the l-sun/chore/disable-toolbar-widget-for-mobile branch from b0906c9 to aad0b75 Compare November 8, 2024 08:35
@L-Sun L-Sun force-pushed the l-sun/feat/mobile-linked-doc-widget branch from 4ccd3a1 to c89cd88 Compare November 8, 2024 09:26
@L-Sun L-Sun force-pushed the l-sun/chore/disable-toolbar-widget-for-mobile branch from aad0b75 to cdf06ed Compare November 8, 2024 09:26
Copy link

graphite-app bot commented Nov 8, 2024

Merge activity

  • Nov 8, 5:23 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 8, 6:23 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'E2E Test (4)').
  • Nov 8, 10:48 PM EST: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 10, 10:55 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 10, 11:11 PM EST: A user merged this pull request with the Graphite merge queue.

@EYHN EYHN force-pushed the l-sun/feat/mobile-linked-doc-widget branch from c89cd88 to 5f40fbc Compare November 8, 2024 11:06
@EYHN EYHN force-pushed the l-sun/chore/disable-toolbar-widget-for-mobile branch from cdf06ed to c89c980 Compare November 8, 2024 11:06
Base automatically changed from l-sun/feat/mobile-linked-doc-widget to canary November 8, 2024 11:22
@L-Sun L-Sun added the merge label Nov 9, 2024
@L-Sun L-Sun force-pushed the l-sun/chore/disable-toolbar-widget-for-mobile branch from c89c980 to 1284f33 Compare November 11, 2024 03:55
@graphite-app graphite-app bot merged commit 1284f33 into canary Nov 11, 2024
46 checks passed
@graphite-app graphite-app bot deleted the l-sun/chore/disable-toolbar-widget-for-mobile branch November 11, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants