Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use custom @ import dialog #8723

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

donteatfriedrice
Copy link
Member

@donteatfriedrice donteatfriedrice commented Nov 6, 2024

Copy link

graphite-app bot commented Nov 6, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @donteatfriedrice and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added mod:i18n Related to i18n test Related to test cases app:core labels Nov 6, 2024
@donteatfriedrice donteatfriedrice marked this pull request as ready for review November 6, 2024 11:04
@donteatfriedrice donteatfriedrice changed the title feat: use custom @ import dislog feat: use custom @ import dialog Nov 6, 2024
@donteatfriedrice donteatfriedrice force-pushed the 11-06-feat_use_custom_import_dislog branch from 1e36839 to f09116e Compare November 6, 2024 11:09
Copy link

nx-cloud bot commented Nov 6, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c323e5a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.10%. Comparing base (d8eda5e) to head (c323e5a).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8723      +/-   ##
==========================================
+ Coverage   70.05%   70.10%   +0.05%     
==========================================
  Files         546      546              
  Lines       33797    33797              
  Branches     3043     3043              
==========================================
+ Hits        23677    23695      +18     
+ Misses       9759     9741      -18     
  Partials      361      361              
Flag Coverage Δ
server-test 77.18% <ø> (+0.06%) ⬆️
unittest 44.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Nov 8, 2024

Merge activity

@donteatfriedrice donteatfriedrice force-pushed the 11-06-feat_use_custom_import_dislog branch from 1db6b1e to c323e5a Compare November 8, 2024 01:53
@graphite-app graphite-app bot merged commit c323e5a into canary Nov 8, 2024
46 checks passed
@graphite-app graphite-app bot deleted the 11-06-feat_use_custom_import_dislog branch November 8, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n mod:infra Environment related issues and discussions test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants