Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): adjust mobile UI #8719

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Nov 6, 2024

  • fix(mobile): add close button for login, close AF-1581
  • fix(mobile): adjust explorer title font, close AF-1575
  • fix(mobile): disable user-select globally, close AF-1626
  • fix(mobile): usage loading ui in setting, close AF-1422
  • fix(mobile): adjust header height, close AF-1574

Copy link

graphite-app bot commented Nov 6, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

CatsJuice commented Nov 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Nov 6, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 06591db. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.05%. Comparing base (add8c56) to head (06591db).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #8719   +/-   ##
=======================================
  Coverage   70.05%   70.05%           
=======================================
  Files         546      546           
  Lines       33797    33797           
  Branches     3043     3043           
=======================================
  Hits        23677    23677           
  Misses       9759     9759           
  Partials      361      361           
Flag Coverage Δ
server-test 77.12% <ø> (ø)
unittest 44.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice changed the title fix(mobile): add close button for login, close AF-1581 fix(mobile): adjust mobile UI Nov 7, 2024
@CatsJuice CatsJuice marked this pull request as ready for review November 7, 2024 02:46
Copy link

graphite-app bot commented Nov 7, 2024

Merge activity

  • Nov 7, 3:53 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 7, 4:09 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'test-build-mobile-app / ios').
  • Nov 7, 7:47 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 7, 8:04 PM EST: A user merged this pull request with the Graphite merge queue.

CatsJuice added a commit that referenced this pull request Nov 7, 2024
- fix(mobile): add close button for login, close AF-1581
- fix(mobile): adjust explorer title font, close AF-1575
- fix(mobile): disable user-select globally, close AF-1626
- fix(mobile): usage loading ui in setting, close AF-1422
- fix(mobile): adjust header height, close AF-1574
@CatsJuice CatsJuice force-pushed the catsjuice/fix/mobile-ui-1106 branch from 2d594dc to 509104d Compare November 7, 2024 08:53
- fix(mobile): add close button for login, close AF-1581
- fix(mobile): adjust explorer title font, close AF-1575
- fix(mobile): disable user-select globally, close AF-1626
- fix(mobile): usage loading ui in setting, close AF-1422
- fix(mobile): adjust header height, close AF-1574
@CatsJuice CatsJuice force-pushed the catsjuice/fix/mobile-ui-1106 branch from 509104d to 06591db Compare November 8, 2024 00:48
@graphite-app graphite-app bot merged commit 06591db into canary Nov 8, 2024
46 checks passed
@graphite-app graphite-app bot deleted the catsjuice/fix/mobile-ui-1106 branch November 8, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants