feat(core): doc database properties #8520

pengx17 · 2024-10-16T15:19:49Z

move inline tags editor to components
add progress component
adjust doc properties styles for desktop
subscribe bs database links and display in doc info
move update/create dates to doc info
a trivial e2e test

🎥 Video uploaded on Graphite:

graphite-app · 2024-10-16T15:20:07Z

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

pengx17 · 2024-10-16T15:20:08Z

feat(core): doc database properties #8520 👈
canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite

nx-cloud · 2024-10-18T06:31:05Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4b6c4ed. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

nx test:coverage @affine/monorepo

Sent with 💌 from NxCloud.

codecov · 2024-10-18T06:34:20Z

Codecov Report

Attention: Patch coverage is 37.93103% with 18 lines in your changes missing coverage. Please review.

Project coverage is 70.29%. Comparing base (f7dc65e) to head (4b6c4ed).
Report is 1 commits behind head on canary.

Files with missing lines	Patch %	Lines
...es/frontend/component/src/ui/property/property.tsx	20.00%	16 Missing ⚠️
...es/frontend/component/src/ui/progress/progress.tsx	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           canary    #8520      +/-   ##
==========================================
+ Coverage   70.24%   70.29%   +0.05%     
==========================================
  Files         534      536       +2     
  Lines       33611    33638      +27     
  Branches     3016     3022       +6     
==========================================
+ Hits        23611    23647      +36     
+ Misses       9645     9636       -9     
  Partials      355      355

Flag	Coverage Δ
server-test	`77.26% <ø> (+0.06%)`	⬆️
unittest	`45.31% <37.93%> (+0.05%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/frontend/core/src/modules/doc-info/services/doc-database-backlinks.ts

graphite-app · 2024-10-24T07:38:10Z

Merge activity

Oct 24, 3:38 AM EDT: A user added this pull request to the Graphite merge queue.
Oct 24, 3:54 AM EDT: A user merged this pull request with the Graphite merge queue.

fix AF-1454 1. move inline tags editor to components 2. add progress component 3. adjust doc properties styles for desktop 4. subscribe bs database links and display in doc info 5. move update/create dates to doc info 6. a trivial e2e test <div class='graphite__hidden'> <div>🎥 Video uploaded on Graphite:</div> <a href="https://app.graphite.dev/media/video/T2klNLEk0wxLh4NRDzhk/eed266c1-fdac-4f0e-baa9-4aa00d14a2e8.mp4"> <img src="https://app.graphite.dev/api/v1/graphite/video/thumbnail/T2klNLEk0wxLh4NRDzhk/eed266c1-fdac-4f0e-baa9-4aa00d14a2e8.mp4"> </a> </div> <video src="https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/T2klNLEk0wxLh4NRDzhk/eed266c1-fdac-4f0e-baa9-4aa00d14a2e8.mp4">10月23日.mp4</video>

github-actions bot added the app:core label Oct 16, 2024

pengx17 force-pushed the 10-16-feat_core_doc_database_properties branch 3 times, most recently from ac9a231 to 876b146 Compare October 17, 2024 10:48

github-actions bot added the mod:component label Oct 17, 2024

pengx17 force-pushed the 10-16-feat_core_doc_database_properties branch from 876b146 to 45c5bf8 Compare October 18, 2024 06:30

pengx17 force-pushed the 10-16-feat_core_doc_database_properties branch from 45c5bf8 to d9a626a Compare October 18, 2024 10:40

pengx17 had a problem deploying to canary October 18, 2024 10:41 — with GitHub Actions Failure

pengx17 force-pushed the 10-16-feat_core_doc_database_properties branch from d9a626a to ac3ebf2 Compare October 18, 2024 12:58

pengx17 temporarily deployed to canary October 18, 2024 12:58 — with GitHub Actions Inactive

pengx17 force-pushed the 10-16-feat_core_doc_database_properties branch from ac3ebf2 to c82bd0d Compare October 18, 2024 14:42

pengx17 temporarily deployed to canary October 18, 2024 14:42 — with GitHub Actions Inactive

pengx17 force-pushed the 10-16-feat_core_doc_database_properties branch from c82bd0d to 276b3d4 Compare October 20, 2024 02:54

pengx17 temporarily deployed to canary October 20, 2024 02:54 — with GitHub Actions Inactive

pengx17 force-pushed the 10-16-feat_core_doc_database_properties branch from 276b3d4 to 52c1421 Compare October 20, 2024 09:48

pengx17 temporarily deployed to canary October 20, 2024 09:48 — with GitHub Actions Inactive

pengx17 force-pushed the 10-16-feat_core_doc_database_properties branch from 52c1421 to c533c77 Compare October 20, 2024 13:32

pengx17 had a problem deploying to canary October 20, 2024 13:32 — with GitHub Actions Error

pengx17 force-pushed the 10-16-feat_core_doc_database_properties branch from c533c77 to 0002c17 Compare October 20, 2024 13:33

pengx17 temporarily deployed to canary October 20, 2024 13:34 — with GitHub Actions Inactive

pengx17 force-pushed the 10-16-feat_core_doc_database_properties branch from 0002c17 to b6f840b Compare October 20, 2024 13:44

pengx17 temporarily deployed to canary October 20, 2024 13:45 — with GitHub Actions Inactive

pengx17 force-pushed the 10-16-feat_core_doc_database_properties branch from b6f840b to f00ef89 Compare October 20, 2024 13:50

pengx17 temporarily deployed to canary October 20, 2024 13:51 — with GitHub Actions Inactive

pengx17 force-pushed the 10-16-feat_core_doc_database_properties branch from f00ef89 to 9766be5 Compare October 21, 2024 06:47

pengx17 temporarily deployed to canary October 21, 2024 06:47 — with GitHub Actions Inactive

pengx17 temporarily deployed to canary October 23, 2024 04:35 — with GitHub Actions Inactive

pengx17 had a problem deploying to canary October 23, 2024 06:18 — with GitHub Actions Error

pengx17 force-pushed the 10-16-feat_core_doc_database_properties branch from 02c3717 to 61100a2 Compare October 23, 2024 07:04

pengx17 temporarily deployed to canary October 23, 2024 07:04 — with GitHub Actions Inactive

EYHN reviewed Oct 23, 2024

View reviewed changes

packages/frontend/core/src/modules/doc-info/services/doc-database-backlinks.ts Outdated Show resolved Hide resolved

pengx17 force-pushed the 10-16-feat_core_doc_database_properties branch from 61100a2 to 6ee4985 Compare October 24, 2024 03:59

pengx17 temporarily deployed to canary October 24, 2024 03:59 — with GitHub Actions Inactive

EYHN approved these changes Oct 24, 2024

View reviewed changes

EYHN force-pushed the 10-16-feat_core_doc_database_properties branch from 6ee4985 to 4b6c4ed Compare October 24, 2024 07:38

EYHN temporarily deployed to canary October 24, 2024 07:39 — with GitHub Actions Inactive

graphite-app bot merged commit 4b6c4ed into canary Oct 24, 2024
40 checks passed

graphite-app bot deleted the 10-16-feat_core_doc_database_properties branch October 24, 2024 07:54

graphite-app bot temporarily deployed to canary October 24, 2024 07:54 Inactive

pengx17 temporarily deployed to canary October 24, 2024 07:59 — with GitHub Actions Inactive

pengx17 temporarily deployed to canary October 24, 2024 08:07 — with GitHub Actions Inactive

github-actions bot temporarily deployed to canary October 24, 2024 09:00 Inactive

github-actions bot temporarily deployed to canary October 24, 2024 09:02 Inactive

github-actions bot temporarily deployed to canary October 24, 2024 09:09 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core): doc database properties #8520

feat(core): doc database properties #8520

pengx17 commented Oct 16, 2024 •

edited

Loading

graphite-app bot commented Oct 16, 2024

pengx17 commented Oct 16, 2024

nx-cloud bot commented Oct 18, 2024 •

edited

Loading

codecov bot commented Oct 18, 2024 •

edited

Loading

graphite-app bot commented Oct 24, 2024 •

edited

Loading

feat(core): doc database properties #8520

feat(core): doc database properties #8520

Conversation

pengx17 commented Oct 16, 2024 • edited Loading

graphite-app bot commented Oct 16, 2024

Your org has enabled the Graphite merge queue for merging into canary

pengx17 commented Oct 16, 2024

nx-cloud bot commented Oct 18, 2024 • edited Loading

☁️ Nx Cloud Report

codecov bot commented Oct 18, 2024 • edited Loading

Codecov Report

graphite-app bot commented Oct 24, 2024 • edited Loading

Merge activity

pengx17 commented Oct 16, 2024 •

edited

Loading

nx-cloud bot commented Oct 18, 2024 •

edited

Loading

codecov bot commented Oct 18, 2024 •

edited

Loading

graphite-app bot commented Oct 24, 2024 •

edited

Loading