Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: frontend copilot metrics #8479

Closed
wants to merge 9 commits into from

Conversation

darkskygit
Copy link
Member

@darkskygit darkskygit commented Oct 11, 2024

fix CLOUD-73

Copy link

graphite-app bot commented Oct 11, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

darkskygit commented Oct 11, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @darkskygit and the rest of your teammates on Graphite Graphite

@darkskygit darkskygit marked this pull request as draft October 11, 2024 08:44
Copy link

nx-cloud bot commented Oct 11, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 783bf3e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.20%. Comparing base (bfc8b93) to head (783bf3e).
Report is 72 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #8479   +/-   ##
=======================================
  Coverage   70.20%   70.20%           
=======================================
  Files         549      549           
  Lines       33891    33891           
  Branches     3042     3042           
=======================================
  Hits        23794    23794           
  Misses       9727     9727           
  Partials      370      370           
Flag Coverage Δ
server-test 77.12% <ø> (ø)
unittest 45.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@darkskygit darkskygit force-pushed the darksky/copilot-statistics branch from 33b2bcb to 1948dcb Compare October 11, 2024 09:13
@darkskygit darkskygit force-pushed the darksky/copilot-frontent-metrics branch from 75e5b3e to 66d751b Compare October 11, 2024 09:13
@darkskygit darkskygit force-pushed the darksky/copilot-statistics branch from 7c649f0 to c10d733 Compare October 14, 2024 06:05
@darkskygit darkskygit force-pushed the darksky/copilot-frontent-metrics branch from 66d751b to bfd5f82 Compare October 14, 2024 06:05
@darkskygit darkskygit marked this pull request as ready for review October 14, 2024 06:06
@darkskygit darkskygit force-pushed the darksky/copilot-frontent-metrics branch from bfd5f82 to 9b8936a Compare October 15, 2024 06:41
@graphite-app graphite-app bot requested a review from Brooooooklyn October 15, 2024 06:41
@github-actions github-actions bot added docs Improvements or additions to documentation mod:component app:electron Related to electron app app:server test Related to test cases labels Oct 15, 2024
@darkskygit darkskygit force-pushed the darksky/copilot-statistics branch from c10d733 to 2e47673 Compare October 16, 2024 07:47
@darkskygit darkskygit force-pushed the darksky/copilot-frontent-metrics branch 2 times, most recently from f3c9240 to c496d37 Compare October 16, 2024 15:47
@darkskygit darkskygit force-pushed the darksky/copilot-statistics branch from 2e47673 to fa554b1 Compare October 18, 2024 03:30
Base automatically changed from darksky/copilot-statistics to canary October 18, 2024 03:43
@darkskygit darkskygit force-pushed the darksky/copilot-frontent-metrics branch from c496d37 to 752a221 Compare October 18, 2024 03:43
Copy link
Member

@forehalo forehalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ai track already done in ai presets

@@ -237,6 +249,15 @@ const PageEvents = {
},
appTabsHeader: {
$: ['tabAction'],
chat: [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reconsider the segment module of ai events, they are in a mess

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current ai track events are chaos, and it may not be possible to complete all the changes in this pr
i will keep the error reporting, move the other changes to the next pr, and continue modifying in next major version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #8546

@darkskygit darkskygit force-pushed the darksky/copilot-frontent-metrics branch from 752a221 to 6066ad6 Compare October 18, 2024 08:40
@darkskygit darkskygit changed the base branch from canary to darksky/copilot-error-handle October 18, 2024 08:40
@darkskygit darkskygit marked this pull request as draft October 18, 2024 08:40
@EYHN EYHN force-pushed the darksky/copilot-error-handle branch from a7a375f to 6f15350 Compare October 22, 2024 05:08
Base automatically changed from darksky/copilot-error-handle to canary October 22, 2024 05:21
@EYHN EYHN force-pushed the darksky/copilot-frontent-metrics branch from 6066ad6 to 31db6cc Compare October 22, 2024 05:21
@darkskygit darkskygit force-pushed the darksky/copilot-frontent-metrics branch from 31db6cc to 3413456 Compare October 22, 2024 13:07
import { isInsideEdgelessEditor } from '@blocksuite/affine/blocks';

export function getTracker(host: EditorHost, inline: boolean) {
return track[isInsideEdgelessEditor(host) ? 'doc' : 'edgeless'].editor[
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ternary operation appears to be swapped. When isInsideEdgelessEditor(host) is true, it should return 'edgeless', not 'doc'. The corrected line should be:

return track[isInsideEdgelessEditor(host) ? 'edgeless' : 'doc'].editor[

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@darkskygit
Copy link
Member Author

outdated, will do this later

@darkskygit darkskygit closed this Nov 21, 2024
@darkskygit darkskygit deleted the darksky/copilot-frontent-metrics branch November 21, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app app:server docs Improvements or additions to documentation mod:component test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants