-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: frontend copilot metrics #8479
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. This stack of pull requests is managed by Graphite. Learn more about stacking. Join @darkskygit and the rest of your teammates on Graphite |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 783bf3e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #8479 +/- ##
=======================================
Coverage 70.20% 70.20%
=======================================
Files 549 549
Lines 33891 33891
Branches 3042 3042
=======================================
Hits 23794 23794
Misses 9727 9727
Partials 370 370
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
33b2bcb
to
1948dcb
Compare
75e5b3e
to
66d751b
Compare
7c649f0
to
c10d733
Compare
66d751b
to
bfd5f82
Compare
bfd5f82
to
9b8936a
Compare
c10d733
to
2e47673
Compare
f3c9240
to
c496d37
Compare
2e47673
to
fa554b1
Compare
c496d37
to
752a221
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ai track already done in ai presets
@@ -237,6 +249,15 @@ const PageEvents = { | |||
}, | |||
appTabsHeader: { | |||
$: ['tabAction'], | |||
chat: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reconsider the segment module of ai events, they are in a mess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
current ai track events are chaos, and it may not be possible to complete all the changes in this pr
i will keep the error reporting, move the other changes to the next pr, and continue modifying in next major version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #8546
752a221
to
6066ad6
Compare
a7a375f
to
6f15350
Compare
6066ad6
to
31db6cc
Compare
31db6cc
to
3413456
Compare
3413456
to
783bf3e
Compare
import { isInsideEdgelessEditor } from '@blocksuite/affine/blocks'; | ||
|
||
export function getTracker(host: EditorHost, inline: boolean) { | ||
return track[isInsideEdgelessEditor(host) ? 'doc' : 'edgeless'].editor[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ternary operation appears to be swapped. When isInsideEdgelessEditor(host)
is true
, it should return 'edgeless'
, not 'doc'
. The corrected line should be:
return track[isInsideEdgelessEditor(host) ? 'edgeless' : 'doc'].editor[
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
outdated, will do this later |
fix CLOUD-73