Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bootstrap support #7072

Closed
wants to merge 3 commits into from
Closed

Conversation

darkskygit
Copy link
Member

@darkskygit darkskygit commented May 26, 2024

fix needing to repeatedly add upgrade prompt migrations
fix AFF-1075

Copy link

graphite-app bot commented May 26, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @darkskygit and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented May 26, 2024

Copy link

codecov bot commented May 26, 2024

Codecov Report

Attention: Patch coverage is 89.36170% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 67.21%. Comparing base (a365acb) to head (2477b3b).

Files Patch % Lines
...kages/backend/server/src/core/bootstrap/service.ts 86.11% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7072      +/-   ##
==========================================
+ Coverage   67.09%   67.21%   +0.11%     
==========================================
  Files         585      588       +3     
  Lines       28885    28978      +93     
  Branches     2609     2620      +11     
==========================================
+ Hits        19381    19477      +96     
+ Misses       9233     9230       -3     
  Partials      271      271              
Flag Coverage Δ
server-test 77.65% <89.36%> (+0.11%) ⬆️
unittest 39.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added test Related to test cases app:core labels May 27, 2024
@darkskygit darkskygit force-pushed the darksky/crycle-prompt-migration branch from 7c8a91a to 2477b3b Compare May 27, 2024 06:07
@forehalo
Copy link
Member

we will soon have an admin panel where we can manage prompts

@darkskygit
Copy link
Member Author

we will soon have an admin panel where we can manage prompts

i think temporary and emergency prompt fixes can use the admin panel, however, all updates still need to be synchronized to the repository
because the content of the prompt is related to the frontend interaction, old versions of prompt may not support future versions of the front end

Copy link
Member

we will soon have an admin panel where we can manage prompts

i think temporary and emergency prompt fixes can use the admin panel, however, all updates still need to be synchronized to the repository
because the content of the prompt is related to the frontend interaction, old versions of prompt may not support future versions of the front end

all prompts are read from db when used, so we will just need to sync the prompts to the latest in case of brand new deployments. Prompts CRUD in admin panel equals data migrations

@darkskygit
Copy link
Member Author

we will soon have an admin panel where we can manage prompts

i think temporary and emergency prompt fixes can use the admin panel, however, all updates still need to be synchronized to the repository
because the content of the prompt is related to the frontend interaction, old versions of prompt may not support future versions of the front end

all prompts are read from db when used, so we will just need to sync the prompts to the latest in case of brand new deployments. Prompts CRUD in admin panel equals data migrations

lgtm

@darkskygit darkskygit closed this May 29, 2024
@darkskygit darkskygit deleted the darksky/crycle-prompt-migration branch May 29, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:server test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants