fix(core): lit portal rerender (#9012)

toeverything · Dec 4, 2024 · dddefcf · dddefcf
1 parent b637a62
commit dddefcf
Showing 1 changed file with 17 additions and 11 deletions.
diff --git a/packages/frontend/component/src/lit-react/lit-portal/lite-portal.tsx b/packages/frontend/component/src/lit-react/lit-portal/lite-portal.tsx
@@ -37,6 +37,23 @@ class LitReactPortal extends LitElement {
     };
   }
 
+  override attributeChangedCallback(
+    name: string,
+    oldVal: string,
+    newVal: string
+  ) {
+    super.attributeChangedCallback(name, oldVal, newVal);
+    if (name.toLowerCase() === 'portalid') {
+      listeners.forEach(l =>
+        l({
+          name: 'willUpdate',
+          target: this,
+          previousPortalId: oldVal,
+        })
+      );
+    }
+  }
+
   // do not enable shadow root
   override createRenderRoot() {
     return this;
@@ -60,17 +77,6 @@ class LitReactPortal extends LitElement {
       })
     );
   }
-
-  override willUpdate(changedProperties: any) {
-    super.willUpdate(changedProperties);
-    listeners.forEach(l =>
-      l({
-        name: 'willUpdate',
-        target: this,
-        previousPortalId: changedProperties.get('portalId'),
-      })
-    );
-  }
 }
 
 declare global {