fix(core): add margin to scrollbar when clientBorder has no style (#6867

) close #6684 https://github.com/toeverything/AFFiNE/assets/102217452/9de18009-c718-4bdd-88fd-caafdb5b419c
toeverything · May 11, 2024 · b8a1fbd · b8a1fbd
1 parent e2b057c
commit b8a1fbd
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/packages/frontend/core/src/pages/workspace/detail-page/detail-page.css.ts b/packages/frontend/core/src/pages/workspace/detail-page/detail-page.css.ts
@@ -32,3 +32,7 @@ export const affineDocViewport = style({
     },
   },
 });
+
+export const scrollbar = style({
+  marginRight: '4px',
+});
diff --git a/packages/frontend/core/src/pages/workspace/detail-page/detail-page.tsx b/packages/frontend/core/src/pages/workspace/detail-page/detail-page.tsx
@@ -1,6 +1,7 @@
 import { Scrollable } from '@affine/component';
 import { PageDetailSkeleton } from '@affine/component/page-detail-skeleton';
 import { PageAIOnboarding } from '@affine/core/components/affine/ai-onboarding';
+import { useAppSettingHelper } from '@affine/core/hooks/affine/use-app-setting-helper';
 import type { PageRootService } from '@blocksuite/blocks';
 import {
   BookmarkService,
@@ -90,6 +91,7 @@ const DetailPageImpl = memo(function DetailPageImpl() {
   const rightSidebar = useService(RightSidebarService).rightSidebar;
   const docCollection = workspace.docCollection;
   const mode = useLiveData(doc.mode$);
+  const { appSettings } = useAppSettingHelper();
 
   const isActiveView = useIsActiveView();
   // TODO: remove jotai here
@@ -252,7 +254,11 @@ const DetailPageImpl = memo(function DetailPageImpl() {
                   docCollection={docCollection}
                 />
               </Scrollable.Viewport>
-              <Scrollable.Scrollbar />
+              <Scrollable.Scrollbar
+                className={clsx({
+                  [styles.scrollbar]: !appSettings.clientBorder,
+                })}
+              />
             </Scrollable.Root>
           </AffineErrorBoundary>
           {isInTrash ? <TrashPageFooter /> : null}
-Original file line number
+Diff line change
@@ Expand Up / @@ -32,3 +32,7 @@ export const affineDocViewport = style({ @@
         },
       },
     });
+    export const scrollbar = style({
+      marginRight: '4px',
+    });