refactor(editor): merge docCreated and docAdded slot

toeverything · Jan 2, 2025 · 75066ef · 75066ef
1 parent f2906bc
commit 75066ef
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 8 deletions.
diff --git a/blocksuite/affine/block-data-view/src/data-source.ts b/blocksuite/affine/block-data-view/src/data-source.ts
@@ -82,7 +82,7 @@ export class BlockQueryDataSource extends DataSourceBase {
     this.workspace.docs.forEach(doc => {
       this.listenToDoc(doc.getDoc());
     });
-    this.workspace.slots.docAdded.on(id => {
+    this.workspace.slots.docCreated.on(id => {
       const doc = this.workspace.getDoc(id);
       if (doc) {
         this.listenToDoc(doc);

diff --git a/blocksuite/framework/store/src/store/collection.ts b/blocksuite/framework/store/src/store/collection.ts
@@ -94,7 +94,6 @@ export class DocCollection {
   meta: DocCollectionMeta;
 
   slots = {
-    docAdded: new Slot<string>(),
     docUpdated: new Slot(),
     docRemoved: new Slot<string>(),
     docCreated: new Slot<string>(),
@@ -163,7 +162,7 @@ export class DocCollection {
         idGenerator: this.idGenerator,
       });
       this.blockCollections.set(doc.id, doc);
-      this.slots.docAdded.emit(doc.id);
+      this.slots.docCreated.emit(doc.id);
     });
 
     this.meta.docMetaUpdated.on(() => this.slots.docUpdated.emit());
@@ -209,7 +208,6 @@ export class DocCollection {
       createDate: Date.now(),
       tags: [],
     });
-    this.slots.docCreated.emit(docId);
     return this.getDoc(docId, { query }) as Doc;
   }
 

diff --git a/blocksuite/playground/apps/starter/utils/collection.ts b/blocksuite/playground/apps/starter/utils/collection.ts
@@ -99,7 +99,7 @@ export async function initStarterDocCollection(collection: DocCollection) {
     let firstDoc = firstCollection?.getDoc();
     if (!firstDoc) {
       await new Promise<string>(resolve =>
-        collection.slots.docAdded.once(resolve)
+        collection.slots.docCreated.once(resolve)
       );
       const firstCollection = collection.docs.values().next().value as
         | BlockCollection

diff --git a/blocksuite/tests-legacy/utils/actions/misc.ts b/blocksuite/tests-legacy/utils/actions/misc.ts
@@ -201,7 +201,7 @@ async function initEmptyEditor({
           window.doc = firstDoc;
           waitForMountPageEditor(firstDoc).catch;
         } else {
-          collection.slots.docAdded.on(docId => {
+          collection.slots.docCreated.on(docId => {
             const doc = collection.getDoc(docId);
             if (!doc) {
               throw new Error(`Failed to get doc ${docId}`);

diff --git a/packages/frontend/core/src/components/hooks/use-block-suite-workspace-page.ts b/packages/frontend/core/src/components/hooks/use-block-suite-workspace-page.ts
@@ -16,7 +16,7 @@ export function useDocCollectionPage(
   useEffect(() => {
     const group = new DisposableGroup();
     group.add(
-      docCollection.slots.docAdded.on(id => {
+      docCollection.slots.docCreated.on(id => {
         if (pageId === id) {
           setPage(docCollection.getDoc(id));
         }

diff --git a/packages/frontend/core/src/components/page-list/use-block-suite-workspace-page.ts b/packages/frontend/core/src/components/page-list/use-block-suite-workspace-page.ts
@@ -16,7 +16,7 @@ export function useDocCollectionPage(
   useEffect(() => {
     const group = new DisposableGroup();
     group.add(
-      docCollection.slots.docAdded.on(id => {
+      docCollection.slots.docCreated.on(id => {
         if (pageId === id) {
           setPage(docCollection.getDoc(id));
         }