Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer code #30

Open
wants to merge 98 commits into
base: master
Choose a base branch
from
Open

Transfer code #30

wants to merge 98 commits into from

Conversation

Ishasharmax
Copy link

No description provided.

MunkyCode and others added 30 commits January 22, 2020 14:35
@MunkyCode
inclass work. Created new tests
423356e
BankAccount is email valid given a definition
9313e80
Gave withdraw tests as well as described how to fix withdraw tests to…
4a00338 
… pass
Comments about partitions and boundary values added to withraw and va…
615fb77 
…lid email tests
isEmailValid updated so all tests pass
117b124
@MunkyCode
switching to desktop
e1f225d
@MunkyCode
updated tests
9b3cbcd
Withdraw and isEmailValid work
740efc5
@MunkyCode
Tests for isAmountValid
712230e
end of class
60dc2ef
@MunkyCode
isAmountValid implamentation added
c5da040
@MunkyCode
tests for illegal aurguments with amounts for constructor and withdraw
2726723
@MunkyCode
added implementation for illegal arguments with constructor and withd…
9fe9214 
…raw. Also removed getbalance tests for negitive starting balance since this is no longer possible
@MunkyCode
added tests for inseficient funds and decimal withdraws
0bdafbe
@MunkyCode
added implementation of inseficeint funds error being throw in withdraw
f5c4b31
@MunkyCode
added a few more tests for isEmailValid
f9c27f5
@MunkyCode
Updated isEmailValid function to include more cases
ab3adb1
@MunkyCode
added tests for deposit
4be5d39
@MunkyCode
added tests for transfer
aca3775
@MunkyCode
changes to tests to be transfer from one object to another rather tha…
4085359 
…n to a theretical email
@MunkyCode
added tests for transfer to include invalid funds exception
b9b9d71
@MunkyCode
added implemntation of deposit and transfer
53d20c1
@MunkyCode
files from class
77e7c1e
@MunkyCode
moving files to the right location
4fec654
@MunkyCode
fixed spelling error
ecaa624
@MunkyCode
added accounts
71c80e7
@MunkyCode
withdraw tests
d6324cd
@MunkyCode
finished implementation of withdraw
be8fd6e
withdrawTests
fce2b20
@mdiallo707
withdraw test and implementation
97351c2
MunkyCode and others added 30 commits February 10, 2020 23:15
@MunkyCode
Update README.md
5ad9738
@mdiallo707
ATM and CheckingAccount deposit and checkBalance implementation and t…
479eb64 
…ests
@mdiallo707
Merge branch 'master' of https://github.com/MunkyCode/SoftwareEnginee…
34118d7 
…ringPractice

# Conflicts:
#	.idea/compiler.xml
#	src/main/java/edu/ithaca/dragon/bank/BankTeller.java
#	src/test/java/edu/ithaca/dragon/bank/BankTellerTest.java
@Ishasharmax
Update README.md
94007b8
@Ishasharmax
Update README.md
56cb5a7
@MunkyCode
Update README.md
aaec46e
@mdiallo707
Merge branch 'master' of https://github.com/MunkyCode/SoftwareEnginee…
7a9f8e9 
…ringPractice

# Conflicts:
#	.idea/compiler.xml
#	src/main/java/edu/ithaca/dragon/bank/BankTeller.java
#	src/test/java/edu/ithaca/dragon/bank/BankTellerTest.java
@mdiallo707
deposit and checkbalance
d2c798c
@mdiallo707
fixing deposit for customerCollection
9f5a450
withdraw tests
2dfb301
withdraw changes 1
22999b4
@MunkyCode
Merge pull request #7 from MunkyCode/withdrawCode
54acf7b 
Withdraw code
@MunkyCode
few last updates
fbab54d
@mari707
Update ReadMe
3833b5a
@mari707
Update ReadMe
2f0bd71
@mari707
Added deposit sequence diagram
51031a8
@Ishasharmax
Update README.md
e59c517
@Ishasharmax
Update README.md
a778e91
@MunkyCode
Update README.md
d2f741f
@MunkyCode
Update README.md
0eb9368
@MunkyCode
change from array list to hashmap
48178c6
@mari707
Merge pull request #8 from MunkyCode/CustomerCollectionMap
86e017d 
change from array list to hashmap
@MunkyCode
changed all exception to be sepcific
5b3fe6e
@MunkyCode
changed all exception to be sepcific
0bb514c
@MunkyCode
tests for addAccount Split
09c819e
@MunkyCode
implementation of createAccoutSplit
aa99112
@MunkyCode
Update README.md
7adbccc
@mari707
Merge pull request #9 from MunkyCode/createAccountSplit
5e1096e 
Create account split
transfer code tests & Implementation
79683ff
@MunkyCode
Merge branch 'master' into TransferCode
5b68158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ishasharmax @MunkyCode @mdiallo707 @mari707