fix: Caching in Github Workflows

Upgraded actions/cache from v2 to v4 Fixed wrong cache key used in nightly-ci.yml Fixes to feast-dev#4056 Signed-off-by: Theodor Mihalache <[email protected]>
tmihalac · Apr 10, 2024 · 08092a1 · 08092a1
1 parent 318a2b8
commit 08092a1
Show file tree

Hide file tree

Showing 12 changed files with 30 additions and 30 deletions.
diff --git a/.github/fork_workflows/fork_pr_integration_tests_aws.yml b/.github/fork_workflows/fork_pr_integration_tests_aws.yml
@@ -34,18 +34,18 @@ jobs:
         run: echo "::set-output name=DOCKER_IMAGE_TAG::`git rev-parse HEAD`"
       - name: Cache Public ECR Image
         id: lambda_python_3_9
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: ~/cache
           key: lambda_python_3_9
       - name: Handle Cache Miss (pull public ECR image & save it to tar file)
-        if: steps.cache-primes.outputs.cache-hit != 'true'
+        if: steps.lambda_python_3_9.outputs.cache-hit != 'true'
         run: |
           mkdir -p ~/cache
           docker pull public.ecr.aws/lambda/python:3.9
           docker save public.ecr.aws/lambda/python:3.9 -o ~/cache/lambda_python_3_9.tar
       - name: Handle Cache Hit (load docker image from tar file)
-        if: steps.cache-primes.outputs.cache-hit == 'true'
+        if: steps.lambda_python_3_9.outputs.cache-hit == 'true'
         run: |
           docker load -i ~/cache/lambda_python_3_9.tar
       - name: Build and push
@@ -114,7 +114,7 @@ jobs:
         run: |
           echo "::set-output name=dir::$(pip cache dir)"
       - name: pip cache
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: |
             ${{ steps.pip-cache.outputs.dir }}

diff --git a/.github/fork_workflows/fork_pr_integration_tests_gcp.yml b/.github/fork_workflows/fork_pr_integration_tests_gcp.yml
@@ -58,7 +58,7 @@ jobs:
         run: |
           echo "::set-output name=dir::$(pip cache dir)"
       - name: pip cache
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: |
             ${{ steps.pip-cache.outputs.dir }}

diff --git a/.github/fork_workflows/fork_pr_integration_tests_snowflake.yml b/.github/fork_workflows/fork_pr_integration_tests_snowflake.yml
@@ -48,7 +48,7 @@ jobs:
         run: |
           echo "::set-output name=dir::$(pip cache dir)"
       - name: pip cache
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: |
             ${{ steps.pip-cache.outputs.dir }}

diff --git a/.github/workflows/java_master_only.yml b/.github/workflows/java_master_only.yml
@@ -72,13 +72,13 @@ jobs:
           java-version: '11'
           java-package: jdk
           architecture: x64
-      - uses: actions/cache@v2
+      - uses: actions/cache@v4
         with:
           path: ~/.m2/repository
           key: ${{ runner.os }}-it-maven-${{ hashFiles('**/pom.xml') }}
           restore-keys: |
             ${{ runner.os }}-it-maven-
-      - uses: actions/cache@v2
+      - uses: actions/cache@v4
         with:
           path: ~/.m2/repository
           key: ${{ runner.os }}-ut-maven-${{ hashFiles('**/pom.xml') }}
@@ -117,7 +117,7 @@ jobs:
         run: |
           echo "::set-output name=dir::$(pip cache dir)"
       - name: pip cache
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: |
             ${{ steps.pip-cache.outputs.dir }}
@@ -133,7 +133,7 @@ jobs:
         run: pip install pip-tools
       - name: Install Python dependencies
         run: make install-python-ci-dependencies
-      - uses: actions/cache@v2
+      - uses: actions/cache@v4
         with:
           path: ~/.m2/repository
           key: ${{ runner.os }}-it-maven-${{ hashFiles('**/pom.xml') }}

diff --git a/.github/workflows/java_pr.yml b/.github/workflows/java_pr.yml
@@ -48,13 +48,13 @@ jobs:
           java-version: '11'
           java-package: jdk
           architecture: x64
-      - uses: actions/cache@v2
+      - uses: actions/cache@v4
         with:
           path: ~/.m2/repository
           key: ${{ runner.os }}-it-maven-${{ hashFiles('**/pom.xml') }}
           restore-keys: |
             ${{ runner.os }}-it-maven-
-      - uses: actions/cache@v2
+      - uses: actions/cache@v4
         with:
           path: ~/.m2/repository
           key: ${{ runner.os }}-ut-maven-${{ hashFiles('**/pom.xml') }}
@@ -130,7 +130,7 @@ jobs:
         with:
           python-version: '3.9'
           architecture: 'x64'
-      - uses: actions/cache@v2
+      - uses: actions/cache@v4
         with:
           path: ~/.m2/repository
           key: ${{ runner.os }}-it-maven-${{ hashFiles('**/pom.xml') }}
@@ -165,7 +165,7 @@ jobs:
         run: |
           echo "::set-output name=dir::$(pip cache dir)"
       - name: pip cache
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: |
             ${{ steps.pip-cache.outputs.dir }}

diff --git a/.github/workflows/linter.yml b/.github/workflows/linter.yml
@@ -20,7 +20,7 @@ jobs:
         run: |
           echo "::set-output name=dir::$(pip cache dir)"
       - name: pip cache
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: |
             ${{ steps.pip-cache.outputs.dir }}

diff --git a/.github/workflows/master_only.yml b/.github/workflows/master_only.yml
@@ -31,18 +31,18 @@ jobs:
         run: echo "::set-output name=DOCKER_IMAGE_TAG::`git rev-parse HEAD`"
       - name: Cache Public ECR Image
         id: lambda_python_3_9
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: ~/cache
           key: lambda_python_3_9
       - name: Handle Cache Miss (pull public ECR image & save it to tar file)
-        if: steps.cache-primes.outputs.cache-hit != 'true'
+        if: steps.lambda_python_3_9.outputs.cache-hit != 'true'
         run: |
           mkdir -p ~/cache
           docker pull public.ecr.aws/lambda/python:3.9
           docker save public.ecr.aws/lambda/python:3.9 -o ~/cache/lambda_python_3_9.tar
       - name: Handle Cache Hit (load docker image from tar file)
-        if: steps.cache-primes.outputs.cache-hit == 'true'
+        if: steps.lambda_python_3_9.outputs.cache-hit == 'true'
         run: |
           docker load -i ~/cache/lambda_python_3_9.tar
       - name: Build and push
@@ -111,7 +111,7 @@ jobs:
         run: |
           echo "::set-output name=dir::$(pip cache dir)"
       - name: pip cache
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: |
             ${{ steps.pip-cache.outputs.dir }}

diff --git a/.github/workflows/nightly-ci.yml b/.github/workflows/nightly-ci.yml
@@ -90,18 +90,18 @@ jobs:
         run: echo "::set-output name=DOCKER_IMAGE_TAG::`git rev-parse HEAD`"
       - name: Cache Public ECR Image
         id: lambda_python_3_9
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: ~/cache
           key: lambda_python_3_9
       - name: Handle Cache Miss (pull public ECR image & save it to tar file)
-        if: steps.cache-primes.outputs.cache-hit != 'true'
+        if: steps.lambda_python_3_9.outputs.cache-hit != 'true'
         run: |
           mkdir -p ~/cache
           docker pull public.ecr.aws/lambda/python:3.9
           docker save public.ecr.aws/lambda/python:3.9 -o ~/cache/lambda_python_3_9.tar
       - name: Handle Cache Hit (load docker image from tar file)
-        if: steps.cache-primes.outputs.cache-hit == 'true'
+        if: steps.lambda_python_3_9.outputs.cache-hit == 'true'
         run: |
           docker load -i ~/cache/lambda_python_3_9.tar
       - name: Build and push
@@ -178,7 +178,7 @@ jobs:
         run: |
           echo "::set-output name=dir::$(pip cache dir)"
       - name: pip cache
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: |
             ${{ steps.pip-cache.outputs.dir }}

diff --git a/.github/workflows/pr_integration_tests.yml b/.github/workflows/pr_integration_tests.yml
@@ -48,18 +48,18 @@ jobs:
         run: echo "::set-output name=DOCKER_IMAGE_TAG::`git rev-parse HEAD`"
       - name: Cache Public ECR Image
         id: lambda_python_3_9
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: ~/cache
           key: lambda_python_3_9
       - name: Handle Cache Miss (pull public ECR image & save it to tar file)
-        if: steps.cache-primes.outputs.cache-hit != 'true'
+        if: steps.lambda_python_3_9.outputs.cache-hit != 'true'
         run: |
           mkdir -p ~/cache
           docker pull public.ecr.aws/lambda/python:3.9
           docker save public.ecr.aws/lambda/python:3.9 -o ~/cache/lambda_python_3_9.tar
       - name: Handle Cache Hit (load docker image from tar file)
-        if: steps.cache-primes.outputs.cache-hit == 'true'
+        if: steps.lambda_python_3_9.outputs.cache-hit == 'true'
         run: |
           docker load -i ~/cache/lambda_python_3_9.tar
       - name: Build and push
@@ -138,7 +138,7 @@ jobs:
         run: |
           echo "::set-output name=dir::$(pip cache dir)"
       - name: pip cache
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: |
             ${{ steps.pip-cache.outputs.dir }}

diff --git a/.github/workflows/pr_local_integration_tests.yml b/.github/workflows/pr_local_integration_tests.yml
@@ -43,7 +43,7 @@ jobs:
         run: |
           echo "::set-output name=dir::$(pip cache dir)"
       - name: pip cache
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: |
             ${{ steps.pip-cache.outputs.dir }}

diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -162,7 +162,7 @@ jobs:
         with:
           python-version: '3.9'
           architecture: 'x64'
-      - uses: actions/cache@v2
+      - uses: actions/cache@v4
         with:
           path: ~/.m2/repository
           key: ${{ runner.os }}-it-maven-${{ hashFiles('**/pom.xml') }}

diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml
@@ -28,7 +28,7 @@ jobs:
         run: |
           echo "::set-output name=dir::$(pip cache dir)"
       - name: pip cache
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: |
             ${{ steps.pip-cache.outputs.dir }}