Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chroma: Replace existing documents with newer versions #1058

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

vogtp
Copy link

@vogtp vogtp commented Nov 1, 2024

I am planing to index our confluence wiki with go langchain.
Therefore I had to be able to replace existing documents in chroma.

This needed the following changes:

  • Introcude a vectorstores.WithIDGenerater option and the according GenerateDocumentID func defaulting to uuid.NewString()
  • Use the new GenerateDocumentID func in chroma (and implemented to the best of my abilites for the rest of the stores).

While at it I realised that the chroma vectorstore did not call the Deduplicater so I fixed this as well.

PR Checklist

  • [x ] Read the Contributing documentation.
  • [x ] Read the Code of conduct documentation.
  • [x ] Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • [ x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [x ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • [ x] Describes the source of new concepts.
  • [ x] References existing implementations as appropriate.
  • [ x] Contains test coverage for new functions.
  • [ x] Passes all golangci-lint checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant