fix(expect-single-argument): Allow no arguments when using nothing (#373

) Closes #176
tlvince · Aug 22, 2024 · 5e95a5a · 5e95a5a
1 parent f9e0798
commit 5e95a5a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/docs/rules/expect-single-argument.md b/docs/rules/expect-single-argument.md
@@ -4,7 +4,7 @@ Ensure `expect` is called with a single argument.
 
 ## Rule details
 
-This rule triggers a warning if `expect` is called with more than one argument or without arguments.
+This rule triggers a warning if `expect` is called with more than one argument or without arguments when not followed by a `nothing()`.
 
 ```js
 expect();
@@ -27,4 +27,5 @@ The following patterns are not warnings:
 expect("something").toEqual("something");
 expect([1, 2, 3]).toEqual([1, 2, 3]);
 expect(true).toBeDefined();
+expect().nothing();
 ```
diff --git a/lib/rules/expect-single-argument.js b/lib/rules/expect-single-argument.js
@@ -14,7 +14,7 @@ function create (context) {
             message: 'Expect must have a single argument. More than one argument were provided.',
             node
           })
-        } else if (node.arguments.length === 0) {
+        } else if (node.arguments.length === 0 && node.parent.property.name !== 'nothing') {
           context.report({
             message: 'Expect must have a single argument. No arguments were provided.',
             node

diff --git a/test/rules/expect-single-argument.js b/test/rules/expect-single-argument.js
@@ -10,7 +10,8 @@ eslintTester.run('expect-single-argument', rule, {
     'expect("something").toEqual("else");',
     'expect(true).toBeDefined();',
     'expect([1, 2, 3]).toEqual([1, 2, 3]);',
-    'expect(undefined).not.toBeDefined();'
+    'expect(undefined).not.toBeDefined();',
+    'expect().nothing();'
   ],
 
   invalid: [