Make RFC compatible behaviour with session ticket #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgePantelakis
force-pushed
the
524-rfc-non-compliant-behaviour-with-session-tickets
branch
from
f2be77a
to
667da27
Compare
Prevent the server from echoing the session_ticket extension when either ticket_count or ticketKeys are not set in settings. tlsfuzzer#524
GeorgePantelakis
force-pushed
the
524-rfc-non-compliant-behaviour-with-session-tickets
branch
from
667da27
to
7ffec11
Compare
tomato42
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @GeorgePantelakis)
|
looks good, thanks! |
GeorgePantelakis
deleted the
524-rfc-non-compliant-behaviour-with-session-tickets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent the server from echoing the session_ticket extension when either ticket_count or ticketKeys are not set in the settings. Attaching capture of a conversation after the change between a tlslite server and openssl s_client.
fixes #524
capture.pcap.txt
This change is