Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating ecc.py wich ecdsa #510

Closed
wants to merge 4 commits into from
Closed

Conversation

gstarovo
Copy link
Contributor

@gstarovo gstarovo commented Feb 21, 2024

  • i have made changes in the keyexchange.py that are regarding encoding and decoding functions from ecc.py
  • i have deleted the corresponding functions from ecc.py and test
  • i tried to implement changes into getCurveByName, but faced several issues:
    • not supported names as we discussed ('secp256r1', 'cesp192r1')
    • supported names, that according to test should not be accepted ('NIST256p' as a name)
  • i did not implement changes in the getPointByteSize function, as it returns the size of the r of the signature and implementing it with only ecdsa seems to be more complicated solution, than the one that already exists. maybe i am wrong.
  • added minor change in the keyexchange.py: generating random private key with ecdsa library

This change is Reviewable

@gstarovo gstarovo closed this Feb 21, 2024
@tomato42
Copy link
Member

instead of deleting the branch you can force push the changes to the same branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants