Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new web: fix constant loading #4277

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

latter-bolden
Copy link
Member

I added loading constants from shared on a previous PR, but it didn't account for the fact that web wasn't populating these in the app package constants module to begin with.

Added support to pull those in from what Vite auto loads and updated the ImportMetaEnv typedef. Confirmed these are available and fixes the new Personal Invite Link cta

Copy link
Member

@patosullivan patosullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good outside of the type issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants