gear: migrate from deprecated packages + use gear #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomholford
force-pushed
the
t/gear
branch
2 times, most recently
from
1f6031f to
68dfc77
Compare
tomholford
changed the title
|
@arthyn Let's go over this tomorrow if you have time. I'd like to make sure the frontend is working as expected given the large delta and recent changes to garden / landscape desks + agent names. |
|
An update on this: just paired with @arthyn to test this locally. Iniitially there were two failing scries: contacts/all and hark/skeins. However, once I installed Talk and sent a DM (and thus populated the test ship's contact store), the scries worked as expected. |
tomholford
changed the title
arthyn
requested changes
Jun 1, 2023
LAND-513 migrate urbit/api to a new gear directory in tloncorp/landscape
|
- copied lib and types from @urbit/api repo to gear/ - migrated webterm types (see: urbit/webterm#3) - rename S3 --> Storage
also uninstall @urbit/api
- remove @urbit/api - remove @urbit/http-api - remove urbit-ob - add @urbit/aura - add urbit/js-http-api (via github repo) - remove all references to @urbit/api - replace with references to @/gear for most types, @urbit/aura for helpers, and js-http-api for network types (via the github repo; replace with npm package when published)
Addresses PR Feedback: restore usage of @urbit/http-api (instead of the new @urbit/js-http-api) for now
- also update @urbit/http-api to latest
- rename s3 stragglers --> storage - also fix Hark tsc issues - install missing deps
- also fix PutEntry type
Before this change, Vite was complaining that the value was being referenced before being defined.
|
@arthyn Thanks for your feedback. I addressed the comments and marked this as ready for re-review |
Co-authored-by: Hunter Miller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is part of an ongoing effort to implement Userspace Permissions UI (#182).
Changes
This set resolves #175
@urbit/apiThis set resolves #176
@urbit/api@urbit/auraFixes LAND-513