Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.10.60 broke pagevar with JuliaGPU docs #995

Open
maleadt opened this issue Feb 1, 2023 · 5 comments
Open

v0.10.60 broke pagevar with JuliaGPU docs #995

maleadt opened this issue Feb 1, 2023 · 5 comments

Comments

@maleadt
Copy link

maleadt commented Feb 1, 2023

It seems like c94317b broke JuliaGPU's use of pagevar: https://github.com/JuliaGPU/juliagpu.org/blob/ff65a83f80ee2baf521f33b103c7412c31af8970/utils.jl#L73

For some reason, for one of our blog posts the pagevar(rpath, :title) returns Nothing:

fpath = "2021-04-09-cuda_3.0"
rpath = "post/2021-04-09-cuda_3.0/index.md"
String "CUDA.jl 3.0"

vs

fpath = "2021-06-10-cuda_3.3"
rpath = "post/2021-06-10-cuda_3.3/index.md"
Nothing nothing

Those two posts look identical, both have a :title section, but for some reason the pagevar lookup fails.

@tlienart
Copy link
Owner

tlienart commented Feb 1, 2023

Could you pin Franklin to 0.10.58 please?

Long story short there's a fix for another pagevar problem that happened after it and I'm now in a crappy position where some people's stuff works with pre 58 and some with post 60 (my fault really...). Anyway I doubt there's anything that went in after 58 that would affect your site though so pinning should be safe in your case.

All this will go away with the next version once I manage to get it in 😅

@maleadt
Copy link
Author

maleadt commented Feb 1, 2023

Yeah sure, it's not a problem, we have the Manifest checked in :-)

@maleadt
Copy link
Author

maleadt commented Jul 11, 2023

Any update here? The latest version still seems to throw this error.

@tlienart
Copy link
Owner

Unless you need a specific fix, I'd keep things pinned at 0.10.58 in your case until 0.11 (currently Xranklin.jl) is released.

Alternatively, you can try adding an @delay in front of this line: https://github.com/JuliaGPU/juliagpu.org/blob/2aff15821133edf77a121998e8506099a11142fb/utils.jl#L66 (i.e. @delay function ... which may help.

fixing this properly in 0.10 would be a significant effort with a high risk of making things break for more people so I'm reluctant to do it, especially when this is properly re-designed in xranklin..

@maleadt
Copy link
Author

maleadt commented Jul 11, 2023

Fair enough! I didn't know about the redesign, waiting for that is no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants