Update ROCm doc #37
Merged
Update ROCm doc #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
maleadt
requested changes
Aug 8, 2023
There was a problem hiding this comment.
Why did you update the dependencies? Newer versions of Franklin.jl have bugs that prevent the site here to deploy, see tlienart/Franklin.jl#995; did you verify everything still works as expected?
|
Everything worked fine for me locally. However I reverted the Manifest to what it was as to avoid any issues. |
|
Huh, weird. Anyway, I think it's safer not to touch the Manifest :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the ROCm doc to match the style and content of the CUDA page from the website, namely:
It fixes #35 and #36