fix hotwired#1241 - cache current page with frame updated

tleish · Jun 24, 2024 · 4b974a3 · 4b974a3
1 parent c4d3fd8
commit 4b974a3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/core/frames/frame_controller.js b/src/core/frames/frame_controller.js
@@ -270,6 +270,8 @@ export class FrameController {
 
   viewRenderedSnapshot(_snapshot, _isPreview, _renderMethod) {}
 
+  setLastRenderedLocation() {}
+
   preloadOnLoadLinksForView(element) {
     session.preloadOnLoadLinksForView(element)
   }
@@ -349,7 +351,7 @@ export class FrameController {
       frame.delegate.fetchResponseLoaded = async (fetchResponse) => {
         if (frame.src) {
           const { statusCode, redirected } = fetchResponse
-          const responseHTML = await fetchResponse.responseHTML
+          const responseHTML = document.documentElement.outerHTML;
           const response = { statusCode, redirected, responseHTML }
           const options = {
             response,

diff --git a/src/tests/functional/frame_navigation_tests.js b/src/tests/functional/frame_navigation_tests.js
@@ -117,8 +117,11 @@ test("promoted frame navigations are cached", async ({ page }) => {
   assert.equal(await page.textContent("#tab-content"), "Two")
   assert.equal(pathname((await page.getAttribute("#tab-frame", "src")) || ""), "/src/tests/fixtures/tabs/two.html")
   assert.equal(await page.getAttribute("#tab-frame", "complete"), "", "caches two.html with [complete]")
+
+  await page.goBack()
+  await nextEventNamed(page, "turbo:load")
 
-
+  assert.equal(await page.textContent("#tab-content"), "One")
   assert.equal(await page.getAttribute("#tab-frame", "src"), null, "caches one.html without #tab-frame[src]")
   assert.equal(await page.getAttribute("#tab-frame", "complete"), null, "caches one.html without [complete]")
 })