feat: mpc swift provider #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't this a rehash of #8 ? |
metalurgical
requested changes
May 20, 2024
There was a problem hiding this comment.
Please see the comments on #8. Many of the same comments apply here.
#if canImport(curveSecp256k1) import curveSecp256k1 #endif
add if canImport(curveSecp256k1)
|
|
||
|
|
||
| public func sign(message: Data) throws -> Data { | ||
| return try self.signer.sign(message: message) |
There was a problem hiding this comment.
I disagree with this.
You're pushing the tss-client from core kit into the dependencies here, where it is already a dependency. This is illustrated with all the extra deps in the tests.
What we should be doing instead in my opinion if you want to do it like this:
- Put
protocol EvmSignerinto it's own package, with basic mock for a test - Import that package here and extend the classes here to conform additionally to
EvmSigner - Build the rest of the relevant signers, plus the tests specific to the signers, either here or in their own packages. Import the evm signer package here.
- Import the EVMSigner protocol package and relevant signer packages into core kit.
- Build tests that integrate core kit and the relevant signers, in core kit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.