Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make threshold in option optional #7

Merged
merged 10 commits into from
Feb 29, 2024
Merged

fix: make threshold in option optional #7

merged 10 commits into from
Feb 29, 2024

Conversation

ieow
Copy link

@ieow ieow commented Feb 26, 2024

make threshold optional and add more tests checking

@ieow ieow marked this pull request as draft February 27, 2024 04:35
@ieow ieow marked this pull request as ready for review February 29, 2024 08:22
himanshuchawla009
himanshuchawla009 approved these changes Feb 29, 2024
View reviewed changes
Copy link

@himanshuchawla009 himanshuchawla009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@himanshuchawla009 himanshuchawla009 merged commit 3f56162 into master Feb 29, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshuchawla009 himanshuchawla009 himanshuchawla009 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ieow @himanshuchawla009