fix: make threshold in option optional

tkey · Feb 26, 2024 · 34885fa · 34885fa
1 parent 46e63d1
commit 34885fa
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/packages/core/src/core.ts b/packages/core/src/core.ts
@@ -394,7 +394,7 @@ class ThresholdKey implements ITKey {
    * getTSSShare accepts a factorKey and returns the TSS share based on the factor encrypted TSS shares in the metadata
    * @param factorKey - factor key
    */
-  async getTSSShare(factorKey: BN, opts?: { threshold: number; accountIndex?: number }): Promise<{ tssIndex: number; tssShare: BN }> {
+  async getTSSShare(factorKey: BN, opts?: { threshold?: number; accountIndex?: number }): Promise<{ tssIndex: number; tssShare: BN }> {
     if (!this.privKey) throw CoreError.default("tss share cannot be returned until you've reconstructed tkey");
     const factorPub = getPubKeyPoint(factorKey);
     const factorEncs = this.getFactorEncs(factorPub);

diff --git a/packages/default/test/RefreshAndAccountIndex.js b/packages/default/test/RefreshAndAccountIndex.js
@@ -1,7 +1,7 @@
 import { ecCurve, getPubKeyPoint } from "@tkey-mpc/common-types";
 // eslint-disable-next-line import/no-extraneous-dependencies
 import { generatePrivate } from "@toruslabs/eccrypto";
-import { fail, notEqual, rejects, strictEqual } from "assert";
+import assert, { fail, notEqual, rejects, strictEqual } from "assert";
 import BN from "bn.js";
 
 import ThresholdKey from "../src/index";
@@ -131,6 +131,22 @@ export const refreshAndAccountIndex = (customSP, manualSync, accountIndexBackwar
         authSignatures: signatures,
       });
 
+      {
+        // ensure tssShare is the master share
+        const { tssShare } = await tb2.getTSSShare(factorKey);
+        const { tssShare: tssShareIndex1 } = await tb2.getTSSShare(factorKey, { accountIndex: 1 });
+        const { tssShare: tssShareIndex2 } = await tb2.getTSSShare(factorKey, { accountIndex: 2 });
+        const { tssShare: tssShareIndex0 } = await tb2.getTSSShare(factorKey, { accountIndex: 0 });
+
+        const nonce1 = tb2.computeAccountNonce(1);
+        const nonce2 = tb2.computeAccountNonce(2);
+
+        assert(tb2.computeAccountNonce(0).eq(new BN(0)), "nonce for account 0 should be 0");
+        assert(tssShare.eq(tssShareIndex0), "tssShareIndex0 should be equal to tssShare");
+        assert(tssShare.add(nonce1).umod(ecCurve.n).eq(tssShareIndex1), "tssShareIndex1 should be equal to tssShare + nonce1");
+        assert(tssShare.add(nonce2).umod(ecCurve.n).eq(tssShareIndex2), "tssShareIndex2 should be equal to tssShare + nonce2");
+        assert(!tssShareIndex1.add(nonce1).umod(ecCurve.n).eq(tssShareIndex2), "tssShareIndex2 should not be equal to tssShareIndex1 + nonce1");
+      }
       // test case to ensure nonce mechanism
       {
         // make sure derived pub key is different from the index 0 key