KDLv2 tracking PR #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm trying to add the options in such a way as to get this backwards compatibility story: - ABI compatibility: a program compiled with an old version should have unchanged behaviour when the library is substituted; This includes not accepting KDLv2 documents. - API compatibility: a program recompiled from source with a new version should (eventually) accept KDLv2 without any further changes. This will be achieved by changing the definition of KDL_DEFAULTS. For now, KDL_DEFAULTS is unchanged, i.e., reject KDLv2 (keeping the tests running)
This change is ABI incompatible because it changes the size of struct kdl_emitter_options
Either behavious is correct; this restores the implementation-specific behaviour tested in kdlv2_test
needed for MSYS v1 tests to pass
|
Current status: the implementation is pretty much done and tested, with a slight question mark regarding multi-line string rules - see kdl-org/kdl#391 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of KDLv2 in ckdl