Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migration name not existing #200

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thatkookooguy
Copy link

current behavior: running migrate down non-existing-migration-name will always run migrate down on the last migration instead of failing

after fix: running will throw the correct error

@wesleytodd
Copy link
Collaborator

Hey! I agree this is a better behavior. Unfortunately we just did a major version rev and I am not sure we can release this without another major version rev. I wonder, could you put this behind a flag so that we can land the feature, then slate a new major in a few months which set's this as the default behavior?

@thatkookooguy
Copy link
Author

sure, sounds great! I'll add a flag to make it not the default

👍🏽

Thanks for the tip!

@wesleytodd wesleytodd force-pushed the main branch 2 times, most recently from 22e0ee8 to 1d2bad4 Compare November 21, 2023 16:01
@wesleytodd
Copy link
Collaborator

Hey @thatkookooguy, I don't see the change to add a flag here. I just merged another PR and was thinking I would do a release. Any interest in updating this? If so I can land it. If not I will probably push a patch release today without it.

@wesleytodd
Copy link
Collaborator

About to push another release without this so just wanted to ping in case you had had time to check it out and add the flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants