Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-2324: Add workflows for development on 5 docs branch #3219

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

MitchC1999
Copy link
Contributor

@MitchC1999 MitchC1999 commented Apr 10, 2024

Ticket: DOC-2324

Site: Staging branch

Changes:

  • Added development and codeql workflows which apply to branches and PRs against tinymce/5 branch

Pre-checks:

  • Branch prefixed with feature/5/ or hotfix/5/

Review:

  • Documentation Team Lead has reviewed

Copy link
Contributor

@kemister85 kemister85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MitchC1999 LGTM, but can you check the below:
`[05:41:23.761] WARN (asciidoctor): id assigned to section already in use: each
file: /home/runner/work/tinymce-docs/tinymce-docs/modules/ROOT/pages/apis/tinymce.dom.domquery.adoc:364
source: /home/runner/work/tinymce-docs/tinymce-docs (branch: HEAD | start path: .)

[05:41:23.817] ERROR (asciidoctor): target of xref not found: apis/tinymce.core.dom.domquery.adoc
file: /home/runner/work/tinymce-docs/tinymce-docs/modules/ROOT/pages/apis/tinymce.dom.domquery.adoc
source: /home/runner/work/tinymce-docs/tinymce-docs (branch: HEAD | start path: .)

[05:41:24.107] ERROR (asciidoctor): target of xref not found: apis/tinymce.editormanager.adoc
file: /home/runner/work/tinymce-docs/tinymce-docs/modules/ROOT/pages/apis/tinymce.editor.adoc
source: /home/runner/work/tinymce-docs/tinymce-docs (branch: HEAD | start path: .)`

@MitchC1999
Copy link
Contributor Author

@kemister85 Those errors are from the api docs, where on 5 there are a couple of apis missing (private), renamed, or with duplicate names. These same errors appear on the current 5 antora docs. They're just something to be aware of, but we will expect these 3 errors to always appear. We can work on removing them at a later date, but it would require a change to moxiedoc or to the 5 branch, so it will take a lot of effort.

@MitchC1999 MitchC1999 merged commit 4649c9d into tinymce/5 Apr 15, 2024
5 checks passed
@MitchC1999 MitchC1999 deleted the feature/5/DOC-2324 branch April 15, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants