Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TINY-10275: Removed clipboard effects #134

Closed
wants to merge 1 commit into from
Closed

Conversation

spocke
Copy link
Member

@spocke spocke commented Oct 31, 2023

Related Ticket: TINY-10275

Description of Changes:

  • Removed the /clipboard effects
  • Removed a test for that
  • Removed the wink.exe
  • Fixed some mistakes around formatting around the last release changelog item.
  • Bump major before release

Pre-checks:

  • Changelog entry added
  • package.json versions have not been changed (done by Lerna on release)
  • Tests have been added (if applicable)

Before merging:

  • Ensure internal dependencies are on appropriate versions
    • For stable releases, all dependencies must be stable
    • For release candidates, all dependencies must be release candidates or stable

@spocke spocke requested a review from a team as a code owner October 31, 2023 08:50
@spocke spocke requested review from TheSpyder, hamza0867, ltrouton, a team, lostkeys, vpyshnenko and HAFRMO and removed request for a team October 31, 2023 08:50
Copy link
Member

@TheSpyder TheSpyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm borderline on this one. We might still need it to test TinyMCE LTS.

At the very least please don't merge it until all tests that use it have been replaced, in case we need to do an emergency bedrock patch for something.

  • wait until the other PRs have merged

@spocke
Copy link
Member Author

spocke commented Nov 3, 2023

I'm borderline on this one. We might still need it to test TinyMCE LTS.

Maybe if we have the infra to run it technically this is only for sanity testing we could make that a manual step for LTS unless we don't have one. It's also only testing this on windows so nothing is tested on other browsers. We could also use older bedrock before this change for LTS.

At the very least please don't merge it until all tests that use it have been replaced, in case we need to do an emergency bedrock patch for something.

Yes, I wanted to get this up for review before I fixed the tests. But I can't fix the tests until the agar change is merged and published as a alpha so right now kind of stuck.

@spocke
Copy link
Member Author

spocke commented Nov 13, 2023

Maybe we park this for a while still think we should get rid of code that we no longer use but there is no rush for it. But if we shutdown the current VMs then this effect will no longer work unless you run the test in local windows VM.

@spocke spocke closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants