Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support runtime: 'bun_workers' #73

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Sep 27, 2023

Benchmarking
$ bun isolate-benchmark.mjs 

> Options: { THREADS: 8, ROUNDS: 2000, IS_BUN: true } 
> 
> Tinypool { runtime: 'bun_workers' } | START
> Tinypool { runtime: 'bun_workers' } | END   12639 ms
> Cooling down for 2s
> .................... ✓
> 
> Native Bun workers | START
> Native Bun workers | END   9924 ms
> Cooling down for 2s
> .................... ✓
$ node isolate-benchmark.mjs 

> Options: { THREADS: 8, ROUNDS: 2000, IS_BUN: false } 
> 
> Tinypool { runtime: 'worker_threds' } | START
> Tinypool { runtime: 'worker_threds' } | END   10354 ms
> Cooling down for 2s
> ................... ✓
> 
> Tinypool { runtime: 'child_process' } | START
> Tinypool { runtime: 'child_process' } | END   13430 ms
> Cooling down for 2s
> ................... ✓
> 
> Native node:worker_threads | START
> Native node:worker_threads | END   9360 ms
> Cooling down for 2s
> ................... ✓

Bun still has issues when thousands of Workers are used: oven-sh/bun#5709. However I don't think Vitest users would run into this as we don't need to recycle workers in Bun - as long as ShadowRealm won't leak memory.

/Users/jarred/actions-runner/_work/WebKit/WebKit/Source/WTF/wtf/posix/ThreadingPOSIX.cpp(497) : size_t WTF::Thread::getRegisters(const ThreadSuspendLocker &, PlatformRegisters &)

TODO: Test with vitest-dev/vitest#4111

@AriPerkkio AriPerkkio mentioned this pull request Sep 27, 2023
@AriPerkkio AriPerkkio force-pushed the feat/support-bun-workers branch from 963e02a to e7e5245 Compare September 28, 2023 04:51
@AriPerkkio AriPerkkio force-pushed the feat/support-bun-workers branch from e7e5245 to 48653dd Compare October 1, 2023 14:04
- Instead of using Node APIs like in tinylibs#70, use Bun's native Workers API
@AriPerkkio AriPerkkio force-pushed the feat/support-bun-workers branch from 48653dd to 5e56748 Compare October 19, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants