Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SetQueryParams in the Provider Interface #18

Merged
merged 3 commits into from
Oct 22, 2024

Commits on Oct 20, 2024

  1. Implement SetQueryParams in the Provider Interface

    - Changed the function signature of the FetchData method in the Provides interface
    - Added the SetQueryParams method to the providers aligned to the concerns raised in tinkershack#13
    
    Resolves tinkershack#13
    References tinkershack#5
    yendelevium committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    85aec3c View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Reduce redundant passing of queryParamters

    - Add queryParams field on the providers
    - Update SetQueryParams method to set the queryParams field on the provider
    - Update NewOpenMeteoProvider() and NewMeteoBlueProvider() to set default QPs on the client
    - Update FetchData() to only set the coords, and not the entire QPs
    yendelevium committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    300545f View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Configuration menu
    Copy the full SHA
    b912216 View commit details
    Browse the repository at this point in the history